public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [REGRESSION] rtc/interface.c: kills suspend-to-ram
@ 2012-04-16  4:36 Mark Lord
  2012-04-16 13:55 ` Mark Lord
  0 siblings, 1 reply; 21+ messages in thread
From: Mark Lord @ 2012-04-16  4:36 UTC (permalink / raw)
  To: Linux Kernel, rtc-linux, Alessandro Zummo, Greg Kroah-Hartman,
	stable

Something recent has killed suspend-to-ram on a number of machines here.
The symptom is that they suspend, but immediately wake up and panic,
with just a black screen so no visible messages to go by.

The patch below works around the issue -- making things work as they used to work.

--- linux/drivers/rtc/interface.c.orig	2012-04-16 00:08:47.615389718 -0400
+++ linux/drivers/rtc/interface.c	2012-04-16 00:09:14.105387382 -0400
@@ -773,7 +773,7 @@
 	if (!rtc->ops || !rtc->ops->alarm_irq_enable)
 		return;

-	rtc->ops->alarm_irq_enable(rtc->dev.parent, false);
+	//rtc->ops->alarm_irq_enable(rtc->dev.parent, false);  // Kills suspend on ZBOX HD-ID41U
 }

 /**


Last known working kernel was 3.2.11.
The line above got added somewhere between it and 3.2.15,
and is also present (no surprise) in newer kernels.

The highest kernel I've tested for this is 3.3.2,
which also fails until I nuke the line shown above.

This is straight x86_64 (Atom) hardware, using rtc-cmos.
I can re-test if anyone has a fix for this.

Meanwhile, whatever patch put this into -stable probably
ought to be reverted upstream and in -stable as well.

Cheers


^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2012-04-27 19:22 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-16  4:36 [REGRESSION] rtc/interface.c: kills suspend-to-ram Mark Lord
2012-04-16 13:55 ` Mark Lord
2012-04-16 14:23   ` richard -rw- weinberger
2012-04-16 15:42     ` Mark Lord
2012-04-16 15:49       ` richard -rw- weinberger
2012-04-16 15:57         ` Mark Lord
2012-04-16 19:45           ` John Stultz
2012-04-16 21:43             ` John Stultz
2012-04-17  2:30               ` Mark Lord
2012-04-17  5:13                 ` John Stultz
2012-04-17 12:51                   ` Mark Lord
2012-04-17 20:11                   ` Mark Lord
2012-04-17 20:12                     ` Mark Lord
2012-04-17 23:02                     ` John Stultz
2012-04-18  1:29                       ` Mark Lord
2012-04-18 18:29                         ` John Stultz
2012-04-27 14:33                           ` Mark Lord
2012-04-27 19:22                             ` John Stultz
2012-04-16 19:44     ` John Stultz
2012-04-17  2:27       ` Mark Lord
2012-04-16 14:26   ` [rtc-linux] " Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox