From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "olof@lixom.net" <olof@lixom.net>,
Colin Cross <ccross@android.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support
Date: Wed, 18 Apr 2012 12:33:50 +0530 [thread overview]
Message-ID: <4F8E6756.80006@nvidia.com> (raw)
In-Reply-To: <4F8DF01D.9040900@wwwdotorg.org>
On Wednesday 18 April 2012 04:05 AM, Stephen Warren wrote:
> On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
>> Add the device info for ALS and proximity sensor isl29018.
>> + isl29018: isl29018@44 {
> I don't think the label "isl29018:" serves any purpose; nothing else
> needs to refer to this node.
>
> I note from http://patchwork.ozlabs.org/patch/132936/ that:
>
> a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
> please comment here?
> b) There's an interrupt signal connected to the device. Can you please
> add that, irrespective of whether the driver uses it.
>
Will do.
> c) This device is also present on Seaboard. Can you update
> tegra-seaboard.dts too? You can find the relevant bus from the link above.
>
Will do.
I will wait for finalizing the vendor prefix before creating the next patch.
This will impact the driver also.
next prev parent reply other threads:[~2012-04-18 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 6:45 [PATCH V1 0/3] ARM: dt: tegra: add ALS and proximity sensor ISL29018 Laxman Dewangan
2012-04-17 6:45 ` [PATCH 1/3] devicetree: Document Intersil Corporation vendor prefix Laxman Dewangan
2012-04-17 6:45 ` [PATCH 2/3] staging: iio: light: of: Fix vendor prefix of isl29018 Laxman Dewangan
2012-04-17 7:15 ` Jonathan Cameron
2012-04-17 6:45 ` [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support Laxman Dewangan
2012-04-17 22:35 ` Stephen Warren
2012-04-18 7:03 ` Laxman Dewangan [this message]
2012-04-19 9:12 ` Laxman Dewangan
2012-04-19 15:31 ` Stephen Warren
2012-04-24 7:42 ` Linus Walleij
2012-04-24 21:08 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8E6756.80006@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=olof@lixom.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox