From: Harald Hoyer <harald@redhat.com>
To: Josh Boyer <jwboyer@redhat.com>
Cc: Matt Carlson <mcarlson@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Hutchings <ben@decadent.org.uk>
Subject: Re: tg3 'No PHY devices' loading issue
Date: Wed, 18 Apr 2012 10:14:47 +0200 [thread overview]
Message-ID: <4F8E77F7.3080300@redhat.com> (raw)
In-Reply-To: <20120417210549.GI19507@zod.bos.redhat.com>
Am 17.04.2012 23:05, schrieb Josh Boyer:
> On Tue, Apr 17, 2012 at 03:39:08PM -0400, Josh Boyer wrote:
>> On Tue, Apr 17, 2012 at 11:50:07AM -0700, Matt Carlson wrote:
>>> On Tue, Apr 17, 2012 at 10:18:57AM -0400, Josh Boyer wrote:
>>>> It has worked on some of the older kernels without the need for the
>>>> manual rmmod/modprobe step, so it seems to be somewhat timing related.
>>>> I'm not sure if there is a module load ordering issue, but that doesn't
>>>> seem to be the case. I can't explain why a later modprobe would work
>>>> just fine though.
>>>>
>>>> Do you have any thoughts on how to go about debugging/fixing this? I'd
>>>> be happy to test and provide whatever information you need.
>>>
>>> The 57788 uses the broadcom phylib module. For some reason, it isn't
>>> available the first module load attempt. A while ago, code was added to
>>> phylib to request modules from userspace if the particular phy support
>>> code wasn't already loaded. It looks like this mechanism isn't working
>>> too well the first time through.
>>>
>>> Can you reproduce the problem if you run 'rmmod broadcom' and then
>>> reload tg3?
>>
>> I'll give it a shot, but that sounds like a quite plausible scenario to
>> me. Oddly, even after the manual modprobe, the broadcom phy module
>> doesn't show an increased use count. There's also no dependency on
>> 'broadcom' listed for tg3 by modinfo.
>
> If I rmmod both tg3 and broadcom and then just load tg3 (either via
> insmod or modprobe), it works fine. It does so because whatever you did
> to make it request the phylib module from userspace also worked because
> the broadcom module is loaded as well.
>
> So it seems my issue is basically because the initramfs isn't built with
> the broadcom module included. I'll have to figure out a way to teach
> dracut what to do here, since it doesn't seem to be automatically
> picking it up (Harald CC'd).
>
> Thanks much for the very quick response from everyone.
>
> josh
Ok, so we have to include all kernel/drivers/net/phy/*.ko in the initramfs?
next prev parent reply other threads:[~2012-04-18 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 14:18 tg3 'No PHY devices' loading issue Josh Boyer
2012-04-17 18:50 ` Matt Carlson
2012-04-17 19:10 ` Ben Hutchings
2012-04-17 19:40 ` Josh Boyer
2012-04-17 20:59 ` Ben Hutchings
2012-04-17 21:07 ` Josh Boyer
2012-04-17 19:39 ` Josh Boyer
2012-04-17 21:05 ` Josh Boyer
2012-04-18 8:14 ` Harald Hoyer [this message]
2012-04-18 11:43 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8E77F7.3080300@redhat.com \
--to=harald@redhat.com \
--cc=ben@decadent.org.uk \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox