From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752941Ab2DRKDa (ORCPT ); Wed, 18 Apr 2012 06:03:30 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:52618 "EHLO e28smtp01.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968Ab2DRKD2 (ORCPT ); Wed, 18 Apr 2012 06:03:28 -0400 Message-ID: <4F8E915E.2010705@linux.vnet.ibm.com> Date: Wed, 18 Apr 2012 18:03:10 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: Takuya Yoshikawa CC: Avi Kivity , Marcelo Tosatti , LKML , KVM Subject: Re: [PATCH v2 07/16] KVM: MMU: introduce for_each_pte_list_spte References: <4F87FA69.5060106@linux.vnet.ibm.com> <4F87FC19.8080404@linux.vnet.ibm.com> <20120414114422.e3fe6e2abbfdcce61e6f69c8@gmail.com> <4F8B93B9.2030801@linux.vnet.ibm.com> <20120417234731.a19f270d5701b11ce95d13d4@gmail.com> In-Reply-To: <20120417234731.a19f270d5701b11ce95d13d4@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit x-cbid: 12041810-4790-0000-0000-0000023BEBD3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/17/2012 10:47 PM, Takuya Yoshikawa wrote: > On Mon, 16 Apr 2012 11:36:25 +0800 > Xiao Guangrong wrote: > >> I tested it with kernbench, no regression is found. > > Because kernbench is not at all good test for this. > >> It is not a problem since the iter and spte should be in the cache. > > I have checked dirty-log-perf myself with this patch [01-07]. > > GET_DIRTY_LOG for 1GB dirty pages has become more than 15% slower. By the way, what is the case did you test? ept = 1 ?