From: David Daney <david.daney@cavium.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Rob Herring <robherring2@gmail.com>,
David Daney <ddaney.cavm@gmail.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"Ben Dooks (embedded platforms)" <ben-linux@fluff.org>,
"Jean Delvare (PC drivers, core)" <khali@linux-fr.org>
Subject: Re: [PATCH 1/5] i2c: Convert i2c-octeon.c to use device tree.
Date: Wed, 18 Apr 2012 09:20:28 -0700 [thread overview]
Message-ID: <4F8EE9CC.20000@cavium.com> (raw)
In-Reply-To: <20120418151621.GF19802@pengutronix.de>
On 04/18/2012 08:16 AM, Wolfram Sang wrote:
>>>> - if (i2c_data == NULL) {
>>>> - dev_err(i2c->dev, "no I2C frequency data\n");
>>>> + /*
>>>> + * "clock-rate" is a legacy binding, the official binding is
>>>> + * "clock-frequency". Try the official one first and then
>>>> + * fall back if it doesn't exist.
>>>> + */
>>>> + data = of_get_property(pdev->dev.of_node, "clock-frequency",&len);
>>>> + if (!data || len != sizeof(*data))
>>>> + data = of_get_property(pdev->dev.of_node, "clock-rate",&len);
>>>> + if (data&& len == sizeof(*data)) {
>>>> + i2c->twsi_freq = be32_to_cpup(data);
>>>
>>> Can't you use of_property_read_u32?
>>
>> I will investigate, and use it if possible.
>
> Any outcome?
Yes, I have implemented Rob's suggestions. A new patch set reflecting
this is coming soon.
>
> And shouldn't the bindings be documented? Or are they only standard and
> we hide the legacy one?
>
Yes, they are documented here:
http://patchwork.linux-mips.org/patch/3536/
look in the cavium-i2c.txt file.
Thanks,
David Daney
next prev parent reply other threads:[~2012-04-18 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 0:27 [PATCH 0/5] MIPS: OCTEON: Convert some device to use Device Tree David Daney
2012-03-27 0:27 ` [PATCH 1/5] i2c: Convert i2c-octeon.c to use device tree David Daney
2012-03-27 1:20 ` Rob Herring
2012-03-27 1:22 ` Rob Herring
2012-03-27 1:29 ` David Daney
2012-04-18 15:16 ` Wolfram Sang
2012-04-18 16:20 ` David Daney [this message]
2012-03-27 0:27 ` [PATCH 2/5] netdev: mdio-octeon.c: Convert " David Daney
2012-03-27 0:27 ` [PATCH 3/5] netdev: octeon_mgmt: " David Daney
2012-03-27 0:27 ` [PATCH 4/5] staging: octeon_ethernet: " David Daney
2012-04-10 16:43 ` Greg Kroah-Hartman
2012-03-27 0:27 ` [PATCH 5/5] MIPS: Octeon: Use device tree to register serial ports David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8EE9CC.20000@cavium.com \
--to=david.daney@cavium.com \
--cc=ben-linux@fluff.org \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=rob.herring@calxeda.com \
--cc=robherring2@gmail.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox