Re: [PATCH 11/12] drivers: staging: rtl8172: Remove unneeded include of version.h

[Larry Finger <Larry.Finger@lwfinger.net>]

On 04/17/2012 11:30 PM, Marcos Paulo de Souza wrote:
> The output of "make versioncheck" told us that:
>
> drivers/staging/rtl8712/osdep_service.h: 32 linux/version.h not needed.
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c: 46 linux/version.h not needed.
>
> If we take a look at these files, we will agree to remove it.
>
> Cc: Larry Finger<Larry.Finger@lwfinger.net>
> Cc: Florian Schilhabel<florian.c.schilhabel@googlemail.com>
> Cc: Greg Kroah-Hartman<gregkh@linuxfoundation.org>
> Cc:<devel@driverdev.osuosl.org>
> Signed-off-by: Marcos Paulo de Souza<marcos.souza.org@gmail.com>
> ---
>   drivers/staging/rtl8712/osdep_service.h       |    1 -
>   drivers/staging/rtl8712/rtl871x_ioctl_linux.c |    1 -
>   2 files changed, 0 insertions(+), 2 deletions(-)

ACKed-by: Larry Finger <Larry.Finger@lwfinger.net>


>
> diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h
> index 9ba6033..cabf774 100644
> --- a/drivers/staging/rtl8712/osdep_service.h
> +++ b/drivers/staging/rtl8712/osdep_service.h
> @@ -29,7 +29,6 @@
>   #define _SUCCESS	1
>   #define _FAIL		0
>
> -#include<linux/version.h>
>   #include<linux/spinlock.h>
>
>   #include<linux/interrupt.h>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index ef35bc2..a44d539 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -43,7 +43,6 @@
>   #include<linux/module.h>
>   #include<linux/kernel.h>
>   #include<linux/init.h>
> -#include<linux/version.h>
>   #include<linux/io.h>
>   #include<linux/semaphore.h>
>   #include<net/iw_handler.h>