From: Kinsbursky Stanislav <skinsbursky@openvz.org>
To: "bfields@fieldses.org" <bfields@fieldses.org>,
"Trond.Myklebust@netapp.com" <Trond.Myklebust@netapp.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devel@openvz.org" <devel@openvz.org>
Subject: Re: [PATCH] LockD: call per-net shutdown on every global shutdown call
Date: Thu, 19 Apr 2012 12:30:24 +0400 [thread overview]
Message-ID: <4F8FCD20.1070103@openvz.org> (raw)
In-Reply-To: <20120418131827.16800.33207.stgit@localhost6.localdomain6>
Please, ignore this patch.
The idea is correct, but current implementation hides few more things to be
modified.
Otherwise kernel oopses.
Sorry.
18.04.2012 17:18, Stanislav Kinsbursky пишет:
> Per-net LockD shutdown call must be called regardless of global nlm users
> counter.
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky@parallels.com>
>
> ---
> fs/lockd/svc.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index 1ead075..2ad3715 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -381,10 +381,9 @@ lockd_down(struct net *net)
> {
> mutex_lock(&nlmsvc_mutex);
> if (nlmsvc_users) {
> - if (--nlmsvc_users) {
> - lockd_down_net(net);
> + lockd_down_net(net);
> + if (--nlmsvc_users)
> goto out;
> - }
> } else {
> printk(KERN_ERR "lockd_down: no users! task=%p\n",
> nlmsvc_task);
>
--
Best regards,
Stanislav Kinsbursky
prev parent reply other threads:[~2012-04-19 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 13:18 [PATCH] LockD: call per-net shutdown on every global shutdown call Stanislav Kinsbursky
2012-04-19 8:30 ` Kinsbursky Stanislav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8FCD20.1070103@openvz.org \
--to=skinsbursky@openvz.org \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox