* [PATCH] LockD: call per-net shutdown on every global shutdown call
@ 2012-04-18 13:18 Stanislav Kinsbursky
2012-04-19 8:30 ` Kinsbursky Stanislav
0 siblings, 1 reply; 2+ messages in thread
From: Stanislav Kinsbursky @ 2012-04-18 13:18 UTC (permalink / raw)
To: bfields, Trond.Myklebust; +Cc: linux-nfs, linux-kernel, devel
Per-net LockD shutdown call must be called regardless of global nlm users
counter.
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
---
fs/lockd/svc.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 1ead075..2ad3715 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -381,10 +381,9 @@ lockd_down(struct net *net)
{
mutex_lock(&nlmsvc_mutex);
if (nlmsvc_users) {
- if (--nlmsvc_users) {
- lockd_down_net(net);
+ lockd_down_net(net);
+ if (--nlmsvc_users)
goto out;
- }
} else {
printk(KERN_ERR "lockd_down: no users! task=%p\n",
nlmsvc_task);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] LockD: call per-net shutdown on every global shutdown call
2012-04-18 13:18 [PATCH] LockD: call per-net shutdown on every global shutdown call Stanislav Kinsbursky
@ 2012-04-19 8:30 ` Kinsbursky Stanislav
0 siblings, 0 replies; 2+ messages in thread
From: Kinsbursky Stanislav @ 2012-04-19 8:30 UTC (permalink / raw)
To: bfields@fieldses.org, Trond.Myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
devel@openvz.org
Please, ignore this patch.
The idea is correct, but current implementation hides few more things to be
modified.
Otherwise kernel oopses.
Sorry.
18.04.2012 17:18, Stanislav Kinsbursky пишет:
> Per-net LockD shutdown call must be called regardless of global nlm users
> counter.
>
> Signed-off-by: Stanislav Kinsbursky<skinsbursky@parallels.com>
>
> ---
> fs/lockd/svc.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> index 1ead075..2ad3715 100644
> --- a/fs/lockd/svc.c
> +++ b/fs/lockd/svc.c
> @@ -381,10 +381,9 @@ lockd_down(struct net *net)
> {
> mutex_lock(&nlmsvc_mutex);
> if (nlmsvc_users) {
> - if (--nlmsvc_users) {
> - lockd_down_net(net);
> + lockd_down_net(net);
> + if (--nlmsvc_users)
> goto out;
> - }
> } else {
> printk(KERN_ERR "lockd_down: no users! task=%p\n",
> nlmsvc_task);
>
--
Best regards,
Stanislav Kinsbursky
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-19 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-18 13:18 [PATCH] LockD: call per-net shutdown on every global shutdown call Stanislav Kinsbursky
2012-04-19 8:30 ` Kinsbursky Stanislav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox