From: Konrad Eisele <konrad@gaisler.com>
To: yong.zhang0@gmail.com
Cc: sam@ravnborg.org, a.p.zijlstra@chello.nl, mingo@elte.hu,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
davem@davemloft.net, daniel@gaisler.com,
Yong Zhang <yong.zhang@windriver.com>
Subject: Re: [PATCH 1/1] sparc32,leon: add notify_cpu_starting()
Date: Fri, 20 Apr 2012 08:32:50 +0200 [thread overview]
Message-ID: <4F910312.3010900@gaisler.com> (raw)
In-Reply-To: <1334903312-18526-1-git-send-email-konrad@gaisler.com>
Hello Yong,
Thank you for the patch, it works. The SMP is fully
functional again for sparc-leon. I just added a "#include<linux/cpu.h>"
to avoid compiler warning.
Please someone in the cc-list, apply.
-- Greetings Konrad
Konrad Eisele wrote:
> From: Yong Zhang<yong.zhang@windriver.com>
>
> Otherwise cpu_active_mask will not set, which lead to other issue.
>
> Signed-off-by: Yong Zhang<yong.zhang0@gmail.com>
> Signed-off-by: Konrad Eisele<konrad@gaisler.com>
> ---
> arch/sparc/kernel/leon_smp.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/sparc/kernel/leon_smp.c b/arch/sparc/kernel/leon_smp.c
> index 1210fde..160cac9 100644
> --- a/arch/sparc/kernel/leon_smp.c
> +++ b/arch/sparc/kernel/leon_smp.c
> @@ -23,6 +23,7 @@
> #include<linux/pm.h>
> #include<linux/delay.h>
> #include<linux/gfp.h>
> +#include<linux/cpu.h>
>
> #include<asm/cacheflush.h>
> #include<asm/tlbflush.h>
> @@ -78,6 +79,8 @@ void __cpuinit leon_callin(void)
> local_flush_tlb_all();
> leon_configure_cache_smp();
>
> + notify_cpu_starting(cpuid);
> +
> /* Get our local ticker going. */
> smp_setup_percpu_timer();
>
next prev parent reply other threads:[~2012-04-20 7:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1334827362-3434-1-git-send-email-konrad@gaisler.com>
2012-04-19 15:34 ` [PATCH 1/1] sparc: task_cpu() for stopper thread on sparc32 returns 0 Sam Ravnborg
2012-04-20 3:36 ` Yong Zhang
2012-04-20 3:56 ` David Miller
2012-04-20 6:28 ` [PATCH 1/1] sparc32,leon: add notify_cpu_starting() Konrad Eisele
2012-04-20 6:32 ` Konrad Eisele [this message]
2012-04-20 7:06 ` David Miller
2012-04-20 7:46 ` [PATCH] " Konrad Eisele
2012-04-20 7:47 ` Konrad Eisele
2012-04-20 8:01 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F910312.3010900@gaisler.com \
--to=konrad@gaisler.com \
--cc=a.p.zijlstra@chello.nl \
--cc=daniel@gaisler.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
--cc=yong.zhang0@gmail.com \
--cc=yong.zhang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox