From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, KVM <kvm@vger.kernel.org>
Subject: [PATCH v3 8/9] KVM: MMU: fix kvm_mmu_pagetable_walk tracepoint
Date: Fri, 20 Apr 2012 16:20:38 +0800 [thread overview]
Message-ID: <4F911C56.7050709@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F911B74.4040305@linux.vnet.ibm.com>
P bit of page fault error code is missed in this tracepoint, fix it by
passing the full error code
Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
---
arch/x86/kvm/mmutrace.h | 7 +++----
arch/x86/kvm/paging_tmpl.h | 3 +--
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kvm/mmutrace.h b/arch/x86/kvm/mmutrace.h
index 84da94f..e762d35 100644
--- a/arch/x86/kvm/mmutrace.h
+++ b/arch/x86/kvm/mmutrace.h
@@ -54,8 +54,8 @@
*/
TRACE_EVENT(
kvm_mmu_pagetable_walk,
- TP_PROTO(u64 addr, int write_fault, int user_fault, int fetch_fault),
- TP_ARGS(addr, write_fault, user_fault, fetch_fault),
+ TP_PROTO(u64 addr, u32 pferr),
+ TP_ARGS(addr, pferr),
TP_STRUCT__entry(
__field(__u64, addr)
@@ -64,8 +64,7 @@ TRACE_EVENT(
TP_fast_assign(
__entry->addr = addr;
- __entry->pferr = (!!write_fault << 1) | (!!user_fault << 2)
- | (!!fetch_fault << 4);
+ __entry->pferr = pferr;
),
TP_printk("addr %llx pferr %x %s", __entry->addr, __entry->pferr,
diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
index 80493fb..8e6aac9 100644
--- a/arch/x86/kvm/paging_tmpl.h
+++ b/arch/x86/kvm/paging_tmpl.h
@@ -154,8 +154,7 @@ static int FNAME(walk_addr_generic)(struct guest_walker *walker,
const int fetch_fault = access & PFERR_FETCH_MASK;
u16 errcode = 0;
- trace_kvm_mmu_pagetable_walk(addr, write_fault, user_fault,
- fetch_fault);
+ trace_kvm_mmu_pagetable_walk(addr, access);
retry_walk:
eperm = false;
walker->level = mmu->root_level;
--
1.7.7.6
next prev parent reply other threads:[~2012-04-20 8:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 8:16 [PATCH v3 0/9] KVM: MMU: fast page fault Xiao Guangrong
2012-04-20 8:17 ` [PATCH v3 1/9] KVM: MMU: return bool in __rmap_write_protect Xiao Guangrong
2012-04-20 8:17 ` [PATCH v3 2/9] KVM: MMU: abstract spte write-protect Xiao Guangrong
2012-04-20 21:33 ` Marcelo Tosatti
2012-04-21 1:10 ` Takuya Yoshikawa
2012-04-21 4:34 ` Xiao Guangrong
2012-04-21 3:24 ` Xiao Guangrong
2012-04-21 4:18 ` Marcelo Tosatti
2012-04-21 6:52 ` Xiao Guangrong
2012-04-20 8:18 ` [PATCH v3 3/9] KVM: VMX: export PFEC.P bit on ept Xiao Guangrong
2012-04-20 8:18 ` [PATCH v3 4/9] KVM: MMU: introduce SPTE_ALLOW_WRITE bit Xiao Guangrong
2012-04-20 21:39 ` Marcelo Tosatti
2012-04-21 3:30 ` Xiao Guangrong
2012-04-21 4:22 ` Marcelo Tosatti
2012-04-21 6:55 ` Xiao Guangrong
2012-04-22 15:12 ` Avi Kivity
2012-04-23 7:24 ` Xiao Guangrong
2012-04-20 8:19 ` [PATCH v3 5/9] KVM: MMU: introduce SPTE_WRITE_PROTECT bit Xiao Guangrong
2012-04-20 21:52 ` Marcelo Tosatti
2012-04-21 0:40 ` Marcelo Tosatti
2012-04-21 0:55 ` Marcelo Tosatti
2012-04-21 1:38 ` Takuya Yoshikawa
2012-04-21 4:29 ` Xiao Guangrong
2012-04-21 4:00 ` Xiao Guangrong
2012-04-24 0:45 ` Marcelo Tosatti
2012-04-24 3:34 ` Xiao Guangrong
2012-04-21 3:47 ` Xiao Guangrong
2012-04-21 4:38 ` Marcelo Tosatti
2012-04-21 7:25 ` Xiao Guangrong
2012-04-24 0:24 ` Marcelo Tosatti
2012-04-20 8:19 ` [PATCH v3 6/9] KVM: MMU: fast path of handling guest page fault Xiao Guangrong
2012-04-20 8:20 ` [PATCH v3 7/9] KVM: MMU: trace fast " Xiao Guangrong
2012-04-20 8:20 ` Xiao Guangrong [this message]
2012-04-20 8:21 ` [PATCH v3 9/9] KVM: MMU: document mmu-lock and " Xiao Guangrong
2012-04-21 0:59 ` [PATCH v3 0/9] KVM: MMU: " Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F911C56.7050709@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox