* [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT.
@ 2012-04-20 8:32 Yuri Matylitski
2012-04-20 9:04 ` Kirill A. Shutemov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yuri Matylitski @ 2012-04-20 8:32 UTC (permalink / raw)
To: Greg Kroah-Hartman, Johan Hovold, Preston Fick, Yuri Matylitski,
Rusty Russell, linux-usb, linux-kernel
Cc: kirill, Yuri Matylitski
Signed-off-by: Yuri Matylitski <ym@tekinsoft.com>
---
drivers/usb/serial/cp210x.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 0310e2d..e56066b 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -287,7 +287,8 @@ static int cp210x_get_config(struct usb_serial_port *port, u8 request,
/* Issue the request, attempting to read 'size' bytes */
result = usb_control_msg(serial->dev, usb_rcvctrlpipe(serial->dev, 0),
request, REQTYPE_DEVICE_TO_HOST, 0x0000,
- port_priv->bInterfaceNumber, buf, size, 300);
+ port_priv->bInterfaceNumber, buf, size,
+ USB_CTRL_GET_TIMEOUT);
/* Convert data into an array of integers */
for (i = 0; i < length; i++)
@@ -340,12 +341,14 @@ static int cp210x_set_config(struct usb_serial_port *port, u8 request,
result = usb_control_msg(serial->dev,
usb_sndctrlpipe(serial->dev, 0),
request, REQTYPE_HOST_TO_DEVICE, 0x0000,
- port_priv->bInterfaceNumber, buf, size, 300);
+ port_priv->bInterfaceNumber, buf, size,
+ USB_CTRL_SET_TIMEOUT);
} else {
result = usb_control_msg(serial->dev,
usb_sndctrlpipe(serial->dev, 0),
request, REQTYPE_HOST_TO_DEVICE, data[0],
- port_priv->bInterfaceNumber, NULL, 0, 300);
+ port_priv->bInterfaceNumber, NULL, 0,
+ USB_CTRL_SET_TIMEOUT);
}
kfree(buf);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT.
2012-04-20 8:32 [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT Yuri Matylitski
@ 2012-04-20 9:04 ` Kirill A. Shutemov
2012-04-20 9:38 ` [PATCH] Fixed usb_control_msg timeout values in cp210x driver Yuri Matylitski
2012-04-20 11:34 ` [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Kirill A. Shutemov @ 2012-04-20 9:04 UTC (permalink / raw)
To: Yuri Matylitski
Cc: Greg Kroah-Hartman, Johan Hovold, Preston Fick, Rusty Russell,
linux-usb, linux-kernel
On Fri, Apr 20, 2012 at 11:32:02AM +0300, Yuri Matylitski wrote:
The first line of the commit message (which is in Subject) should be a
short summary of the change. More detailed description should be added
after an empty line.
More commit message hints:
http://who-t.blogspot.com/2009/12/on-commit-messages.html
Otherwise:
Acked-by: Kirill A. Shutemov <kirill@shutemov.name>
> Signed-off-by: Yuri Matylitski <ym@tekinsoft.com>
> ---
> drivers/usb/serial/cp210x.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index 0310e2d..e56066b 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -287,7 +287,8 @@ static int cp210x_get_config(struct usb_serial_port *port, u8 request,
> /* Issue the request, attempting to read 'size' bytes */
> result = usb_control_msg(serial->dev, usb_rcvctrlpipe(serial->dev, 0),
> request, REQTYPE_DEVICE_TO_HOST, 0x0000,
> - port_priv->bInterfaceNumber, buf, size, 300);
> + port_priv->bInterfaceNumber, buf, size,
> + USB_CTRL_GET_TIMEOUT);
>
> /* Convert data into an array of integers */
> for (i = 0; i < length; i++)
> @@ -340,12 +341,14 @@ static int cp210x_set_config(struct usb_serial_port *port, u8 request,
> result = usb_control_msg(serial->dev,
> usb_sndctrlpipe(serial->dev, 0),
> request, REQTYPE_HOST_TO_DEVICE, 0x0000,
> - port_priv->bInterfaceNumber, buf, size, 300);
> + port_priv->bInterfaceNumber, buf, size,
> + USB_CTRL_SET_TIMEOUT);
> } else {
> result = usb_control_msg(serial->dev,
> usb_sndctrlpipe(serial->dev, 0),
> request, REQTYPE_HOST_TO_DEVICE, data[0],
> - port_priv->bInterfaceNumber, NULL, 0, 300);
> + port_priv->bInterfaceNumber, NULL, 0,
> + USB_CTRL_SET_TIMEOUT);
> }
>
> kfree(buf);
> --
> 1.7.0.4
>
--
Kirill A. Shutemov
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Fixed usb_control_msg timeout values in cp210x driver
2012-04-20 8:32 [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT Yuri Matylitski
2012-04-20 9:04 ` Kirill A. Shutemov
@ 2012-04-20 9:38 ` Yuri Matylitski
2012-04-20 11:34 ` [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Yuri Matylitski @ 2012-04-20 9:38 UTC (permalink / raw)
To: Greg Kroah-Hartman, Johan Hovold, Preston Fick, Yuri Matylitski,
Rusty Russell, linux-usb, linux-kernel
Cc: kirill, Yuri Matylitski
Fixed too small hardcoded timeout values for usb_control_msg
in driver for SiliconLabs cp210x-based usb-to-serial adapters.
Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT.
Signed-off-by: Yuri Matylitski <ym@tekinsoft.com>
Acked-by: Kirill A. Shutemov <kirill@shutemov.name>
---
drivers/usb/serial/cp210x.c | 9 ++++++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 0310e2d..e56066b 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -287,7 +287,8 @@ static int cp210x_get_config(struct usb_serial_port *port, u8 request,
/* Issue the request, attempting to read 'size' bytes */
result = usb_control_msg(serial->dev, usb_rcvctrlpipe(serial->dev, 0),
request, REQTYPE_DEVICE_TO_HOST, 0x0000,
- port_priv->bInterfaceNumber, buf, size, 300);
+ port_priv->bInterfaceNumber, buf, size,
+ USB_CTRL_GET_TIMEOUT);
/* Convert data into an array of integers */
for (i = 0; i < length; i++)
@@ -340,12 +341,14 @@ static int cp210x_set_config(struct usb_serial_port *port, u8 request,
result = usb_control_msg(serial->dev,
usb_sndctrlpipe(serial->dev, 0),
request, REQTYPE_HOST_TO_DEVICE, 0x0000,
- port_priv->bInterfaceNumber, buf, size, 300);
+ port_priv->bInterfaceNumber, buf, size,
+ USB_CTRL_SET_TIMEOUT);
} else {
result = usb_control_msg(serial->dev,
usb_sndctrlpipe(serial->dev, 0),
request, REQTYPE_HOST_TO_DEVICE, data[0],
- port_priv->bInterfaceNumber, NULL, 0, 300);
+ port_priv->bInterfaceNumber, NULL, 0,
+ USB_CTRL_SET_TIMEOUT);
}
kfree(buf);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT.
2012-04-20 8:32 [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT Yuri Matylitski
2012-04-20 9:04 ` Kirill A. Shutemov
2012-04-20 9:38 ` [PATCH] Fixed usb_control_msg timeout values in cp210x driver Yuri Matylitski
@ 2012-04-20 11:34 ` Sergei Shtylyov
2 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2012-04-20 11:34 UTC (permalink / raw)
To: Yuri Matylitski
Cc: Greg Kroah-Hartman, Johan Hovold, Preston Fick, Rusty Russell,
linux-usb, linux-kernel, kirill
Hello.
On 20-04-2012 12:32, Yuri Matylitski wrote:
Your subject is far too long. Part of it probabbly should constitute the
change log.
> Signed-off-by: Yuri Matylitski<ym@tekinsoft.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-04-20 11:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-20 8:32 [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT Yuri Matylitski
2012-04-20 9:04 ` Kirill A. Shutemov
2012-04-20 9:38 ` [PATCH] Fixed usb_control_msg timeout values in cp210x driver Yuri Matylitski
2012-04-20 11:34 ` [PATCH] Fixed too small hardcoded timeout values for usb_control_msg in driver for SiliconLabs cp210x-based usb-to-serial adapters. Replaced with USB_CTRL_GET_TIMEOUT/USB_CTRL_SET_TIMEOUT Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox