From: Laxman Dewangan <ldewangan@nvidia.com>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Stephen Warren <swarren@nvidia.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH V1] dmaengine: tegra: add dma driver
Date: Fri, 20 Apr 2012 19:15:14 +0530 [thread overview]
Message-ID: <4F91686A.1030000@nvidia.com> (raw)
In-Reply-To: <4F9153AF.7020901@nvidia.com>
Hi Vinod,
On Friday 20 April 2012 05:46 PM, Laxman Dewangan wrote:
> Thanks Vinod for quick review.
>
>>> + * @dma_dev: required DMA master client device.
>>> + * @dm_req_id: Peripheral dma requestor ID.
>>> + */
>>> +struct tegra_dma_slave {
>>> + struct device *client_dev;
>>> + enum tegra_dma_requestor dma_req_id;
>>> + enum tegra_dma_burst_size burst_size;
>> pls remove
> if above is OK then I can remove this.
>
If I add one more member as slave_id for slave requester in struct
dma_slave_config then I will not need the tegra_dma header at all and I
can get rid of this file.
Let me know if this is OK so that I can take care of this in my next patch.
Thanks,
Laxman
next prev parent reply other threads:[~2012-04-20 13:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 9:08 [PATCH V1] dmaengine: tegra: add dma driver Laxman Dewangan
2012-04-20 11:14 ` Vinod Koul
2012-04-20 12:16 ` Laxman Dewangan
2012-04-20 13:45 ` Laxman Dewangan [this message]
2012-04-23 8:41 ` Vinod Koul
2012-04-23 12:17 ` Laxman Dewangan
2012-04-23 12:23 ` Vinod Koul
2012-04-23 13:06 ` Russell King - ARM Linux
2012-04-23 13:17 ` Laxman Dewangan
2012-04-25 9:01 ` Laxman Dewangan
2012-04-25 9:33 ` Vinod Koul
2012-04-25 9:42 ` Laxman Dewangan
2012-04-25 9:43 ` Vinod Koul
2012-04-25 9:58 ` Laxman Dewangan
2012-04-25 10:35 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F91686A.1030000@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox