From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756334Ab2DTW5a (ORCPT ); Fri, 20 Apr 2012 18:57:30 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:54377 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755568Ab2DTW53 (ORCPT ); Fri, 20 Apr 2012 18:57:29 -0400 Message-ID: <4F91E9C1.4050102@linaro.org> Date: Fri, 20 Apr 2012 15:57:05 -0700 From: John Stultz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Greg KH CC: Linux Kernel , Colin Cross , Thomas Gleixner , Android Kernel Team Subject: Re: [PATCH 0/4] Android Alarm Driver Cleanups (for staging-next/3.5) References: <1334950307-403-1-git-send-email-john.stultz@linaro.org> <20120420220849.GA5642@kroah.com> In-Reply-To: <20120420220849.GA5642@kroah.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12042022-4242-0000-0000-000001698664 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/20/2012 03:08 PM, Greg KH wrote: > On Fri, Apr 20, 2012 at 12:31:43PM -0700, John Stultz wrote: >> Greg: Would you mind applying this set to staging-next for 3.5? > It took some messing with (due to some over-eager people fixing spelling > mistakes and compiler warnings that you didn't have in your tree), but > I've applied these now. Thanks for doing this work. > > But, as I already said, this patch set produces some big compiler > warnings, can you please fix them up before I get nasty messages from > the linux-next maintainer? Ok. So I manged to trigger the warning at patch 3/4 too. However, patch 4/4 resolves it. The problem is the android alarm driver and the alarmtimer code have a naming collision with "struct alarm", and there were some macros (see CONFIG_ANDROID_ALARM_OLDDRV_COMPAT in staging/android/android_alarm.h before these patches) that allow a easier transition over to the new code for out of tree drivers. Ideally I would have yanked those macros in 3/4 instead of 4/4. But after 4/4 is applied the issue should not longer be present (at least I've not been able to trigger it) Do you want me to respin the last two patches? thanks -john