From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: David Brown <davidb@codeaurora.org>
Cc: Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] video: msm: Fix section mismatches in mddi.c
Date: Mon, 23 Apr 2012 06:16:55 +0000 [thread overview]
Message-ID: <4F94F3D7.5030904@gmx.de> (raw)
In-Reply-To: <1334256334-8234-1-git-send-email-davidb@codeaurora.org>
On 04/12/2012 06:45 PM, David Brown wrote:
> The change
> commit 461cbe77d0a4f887c33a3a95ea68a7daf23b4302
> Author: Gregory Bean <gbean@codeaurora.org>
> Date: Wed Jul 28 10:22:13 2010 -0700
>
> video: msm: Fix section mismatch in mddi.c.
>
> fixes a section mismatch between the board file and the driver's probe
> function, however, it misses the additional mismatches between the
> probe function and some routines it calls. Fix these up as well.
>
> Signed-off-by: David Brown <davidb@codeaurora.org>
Applied.
Thanks,
Florian Tobias Schandinat
> ---
> drivers/video/msm/mddi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/msm/mddi.c b/drivers/video/msm/mddi.c
> index 4527cbf..b061d70 100644
> --- a/drivers/video/msm/mddi.c
> +++ b/drivers/video/msm/mddi.c
> @@ -420,7 +420,7 @@ static void mddi_resume(struct msm_mddi_client_data *cdata)
> mddi_set_auto_hibernate(&mddi->client_data, 1);
> }
>
> -static int __init mddi_get_client_caps(struct mddi_info *mddi)
> +static int __devinit mddi_get_client_caps(struct mddi_info *mddi)
> {
> int i, j;
>
> @@ -622,9 +622,9 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
>
> static struct mddi_info mddi_info[2];
>
> -static int __init mddi_clk_setup(struct platform_device *pdev,
> - struct mddi_info *mddi,
> - unsigned long clk_rate)
> +static int __devinit mddi_clk_setup(struct platform_device *pdev,
> + struct mddi_info *mddi,
> + unsigned long clk_rate)
> {
> int ret;
>
next prev parent reply other threads:[~2012-04-23 6:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 18:45 [PATCH 1/2] video: msm: Fix section mismatches in mddi.c David Brown
2012-04-12 18:45 ` [PATCH 2/2] ARM: msm: Fix section mismatches in proc_comm.c David Brown
2012-04-23 6:16 ` Florian Tobias Schandinat [this message]
2012-04-23 16:19 ` [PATCH 1/2] video: msm: Fix section mismatches in mddi.c David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F94F3D7.5030904@gmx.de \
--to=florianschandinat@gmx.de \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox