* [PATCH] drivers/video/mbx/mbxfb.c: correct ioremap_nocache test
@ 2012-04-18 20:07 Julia Lawall
2012-04-23 6:19 ` Florian Tobias Schandinat
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2012-04-18 20:07 UTC (permalink / raw)
To: Florian Tobias Schandinat; +Cc: kernel-janitors, linux-fbdev, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The test tested not the most recently allocated value but a previously
allocated one.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/video/mbx/mbxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c
index 55bf619..ab0a8e5 100644
--- a/drivers/video/mbx/mbxfb.c
+++ b/drivers/video/mbx/mbxfb.c
@@ -950,7 +950,7 @@ static int __devinit mbxfb_probe(struct platform_device *dev)
mfbi->fb_virt_addr = ioremap_nocache(mfbi->fb_phys_addr,
res_size(mfbi->fb_req));
- if (!mfbi->reg_virt_addr) {
+ if (!mfbi->fb_virt_addr) {
dev_err(&dev->dev, "failed to ioremap frame buffer\n");
ret = -EINVAL;
goto err4;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/video/mbx/mbxfb.c: correct ioremap_nocache test
2012-04-18 20:07 [PATCH] drivers/video/mbx/mbxfb.c: correct ioremap_nocache test Julia Lawall
@ 2012-04-23 6:19 ` Florian Tobias Schandinat
0 siblings, 0 replies; 2+ messages in thread
From: Florian Tobias Schandinat @ 2012-04-23 6:19 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, linux-fbdev, linux-kernel
On 04/18/2012 08:07 PM, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The test tested not the most recently allocated value but a previously
> allocated one.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
Thanks,
Florian Tobias Schandinat
>
> ---
> drivers/video/mbx/mbxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/mbx/mbxfb.c b/drivers/video/mbx/mbxfb.c
> index 55bf619..ab0a8e5 100644
> --- a/drivers/video/mbx/mbxfb.c
> +++ b/drivers/video/mbx/mbxfb.c
> @@ -950,7 +950,7 @@ static int __devinit mbxfb_probe(struct platform_device *dev)
>
> mfbi->fb_virt_addr = ioremap_nocache(mfbi->fb_phys_addr,
> res_size(mfbi->fb_req));
> - if (!mfbi->reg_virt_addr) {
> + if (!mfbi->fb_virt_addr) {
> dev_err(&dev->dev, "failed to ioremap frame buffer\n");
> ret = -EINVAL;
> goto err4;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-23 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-18 20:07 [PATCH] drivers/video/mbx/mbxfb.c: correct ioremap_nocache test Julia Lawall
2012-04-23 6:19 ` Florian Tobias Schandinat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox