From: Juri Lelli <juri.lelli@gmail.com>
To: Hillf Danton <dhillf@gmail.com>
Cc: Dario Faggioli <raistlin@linux.it>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] DLS: cleanup clearing overload
Date: Mon, 23 Apr 2012 08:57:42 +0200 [thread overview]
Message-ID: <4F94FD66.2050707@gmail.com> (raw)
In-Reply-To: <CAJd=RBA0Qymw3dadvv5WntVNOr22rn7XPYe0SivY9F+SH1gofw@mail.gmail.com>
On 04/08/2012 01:33 PM, Hillf Danton wrote:
> We have to info puller that there is no more diet, even if CPU goes off.
>
> Signed-off-by: Hillf Danton<dhillf@gmail.com>
> ---
>
> --- a/kernel/sched_dl.c Sat Apr 7 15:00:28 2012
> +++ b/kernel/sched_dl.c Sun Apr 8 19:24:30 2012
> @@ -83,9 +83,6 @@ static inline void dl_set_overload(struc
>
> static inline void dl_clear_overload(struct rq *rq)
> {
> - if (!rq->online)
> - return;
> -
This check should have been inserted in -rt with this:
http://lists-archives.com/linux-kernel/15208730-sched-fix-cpupri-hotplug-support.html
As stated in the changlog, it was inserted to resolve a
bug related to hotplug. Most probably the same problem
would affect us, so I would not remove that check.
Thanks,
- Juri
prev parent reply other threads:[~2012-04-23 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-08 11:33 [PATCH] DLS: cleanup clearing overload Hillf Danton
2012-04-23 6:57 ` Juri Lelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F94FD66.2050707@gmail.com \
--to=juri.lelli@gmail.com \
--cc=dhillf@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raistlin@linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox