[PATCH] DLS: cleanup clearing overload

[PATCH] DLS: cleanup clearing overload

[Hillf Danton]

We have to info puller that there is no more diet, even if CPU goes off.

Signed-off-by: Hillf Danton <dhillf@gmail.com>
---

--- a/kernel/sched_dl.c	Sat Apr  7 15:00:28 2012
+++ b/kernel/sched_dl.c	Sun Apr  8 19:24:30 2012
@@ -83,9 +83,6 @@ static inline void dl_set_overload(struc

 static inline void dl_clear_overload(struct rq *rq)
 {
-	if (!rq->online)
-		return;
-
 	atomic_dec(&rq->rd->dlo_count);
 	cpumask_clear_cpu(rq->cpu, rq->rd->dlo_mask);
 }
--

Re: [PATCH] DLS: cleanup clearing overload

[Juri Lelli]

On 04/08/2012 01:33 PM, Hillf Danton wrote:
> We have to info puller that there is no more diet, even if CPU goes off.
>
> Signed-off-by: Hillf Danton<dhillf@gmail.com>
> ---
>
> --- a/kernel/sched_dl.c	Sat Apr  7 15:00:28 2012
> +++ b/kernel/sched_dl.c	Sun Apr  8 19:24:30 2012
> @@ -83,9 +83,6 @@ static inline void dl_set_overload(struc
>
>   static inline void dl_clear_overload(struct rq *rq)
>   {
> -	if (!rq->online)
> -		return;
> -

This check should have been inserted in -rt with this:
http://lists-archives.com/linux-kernel/15208730-sched-fix-cpupri-hotplug-support.html
As stated in the changlog, it was inserted to resolve a
bug related to hotplug. Most probably the same problem
would affect us, so I would not remove that check.

Thanks,

- Juri