From: Mike Miller <mike.miller@hp.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Chirag Kantharia <chirag.kantharia@hp.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
ISS StorageDev <iss_storagedev@hp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/block/cpqarray.c: add missing cmd_free
Date: Mon, 23 Apr 2012 10:01:19 -0500 [thread overview]
Message-ID: <4F956EBF.7020506@hp.com> (raw)
In-Reply-To: <1335086112-10528-1-git-send-email-Julia.Lawall@lip6.fr>
On 04/22/2012 04:15 AM, Julia Lawall wrote:
> From: Julia Lawall<Julia.Lawall@lip6.fr>
>
> Call cmd_free(h, c, 0); before leaving the function as done on all other
> exit paths.
>
> Signed-off-by: Julia Lawall<Julia.Lawall@lip6.fr>
Acked-by: Mike Miller <mike.miller@hp.com>
>
> ---
> drivers/block/cpqarray.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
> index 9125bbe..db6f15d 100644
> --- a/drivers/block/cpqarray.c
> +++ b/drivers/block/cpqarray.c
> @@ -1334,6 +1334,7 @@ static int ida_ctlr_ioctl(ctlr_info_t *h, int dsk, ida_ioctl_t *io)
> case READ_FLASH_ROM:
> if (copy_to_user(io->sg[0].addr, p, io->sg[0].size)) {
> kfree(p);
> + cmd_free(h, c, 0);
> return -EFAULT;
> }
> /* fall through and free p */
>
prev parent reply other threads:[~2012-04-23 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-22 9:15 [PATCH] drivers/block/cpqarray.c: add missing cmd_free Julia Lawall
2012-04-23 15:01 ` Mike Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F956EBF.7020506@hp.com \
--to=mike.miller@hp.com \
--cc=Julia.Lawall@lip6.fr \
--cc=chirag.kantharia@hp.com \
--cc=iss_storagedev@hp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox