From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753283Ab2DWPkH (ORCPT ); Mon, 23 Apr 2012 11:40:07 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:52672 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013Ab2DWPkE (ORCPT ); Mon, 23 Apr 2012 11:40:04 -0400 Message-ID: <4F9577CF.2020400@gmail.com> Date: Mon, 23 Apr 2012 17:39:59 +0200 From: Juri Lelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Peter Zijlstra CC: tglx@linutronix.de, mingo@redhat.com, rostedt@goodmis.org, cfriesen@nortel.com, oleg@redhat.com, fweisbec@gmail.com, darren@dvhart.com, johan.eker@ericsson.com, p.faure@akatech.ch, linux-kernel@vger.kernel.org, claudio@evidence.eu.com, michael@amarulasolutions.com, fchecconi@gmail.com, tommaso.cucinotta@sssup.it, nicola.manica@disi.unitn.it, luca.abeni@unitn.it, dhaval.giani@gmail.com, hgu1972@gmail.com, paulmck@linux.vnet.ibm.com, raistlin@linux.it, insop.song@ericsson.com, liming.wang@windriver.com Subject: Re: [PATCH 05/16] sched: SCHED_DEADLINE policy implementation. References: <1333696481-3433-1-git-send-email-juri.lelli@gmail.com> <1333696481-3433-6-git-send-email-juri.lelli@gmail.com> <1335191701.28150.155.camel@twins> In-Reply-To: <1335191701.28150.155.camel@twins> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/23/2012 04:35 PM, Peter Zijlstra wrote: > On Fri, 2012-04-06 at 09:14 +0200, Juri Lelli wrote: >> +static void init_dl_task_timer(struct sched_dl_entity *dl_se) >> +{ >> + struct hrtimer *timer =&dl_se->dl_timer; >> + >> + if (hrtimer_active(timer)) { >> + hrtimer_try_to_cancel(timer); >> + return; >> + } > > Same question I guess, how can it be active here? Also, just letting it > run doesn't seem like the best way out.. > Probably s/hrtimer_try_to_cancel/hrtimer_cancel is better. >> + >> + hrtimer_init(timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); >> + timer->function = dl_task_timer; >> + timer->irqsafe = 1; >> +} Thanks, - Juri