public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jiandong Zheng" <jdzheng@broadcom.com>
To: "Christian Dietrich" <dietrich@cs.fau.de>
Cc: "Scott Branden" <sbranden@broadcom.com>,
	"Russell King" <linux@arm.linux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	vamos-dev@i4.informatik.uni-erlangen.de
Subject: Re: Possible integer overflow in mach-bcmring with FPGA11107
Date: Mon, 23 Apr 2012 13:19:29 -0700	[thread overview]
Message-ID: <4F95B951.6020700@broadcom.com> (raw)
In-Reply-To: <86r4veipp8.fsf@gandalf.zerties.org>

On 4/23/2012 5:43 AM, Christian Dietrich wrote:
>
> This seems totally innocent, but when doing the caluculation for
> rate_hz by hand (or python) the result is slighly bigger than
> 2^32-1. Therfore an integer overflow should occur and the rate_hz rate
> will be far too low. It may be that there is a sanity check in
> hardware, but i don't know the used hardware at all.
>
Hi Christian,

Yes. This is a problem. I will cleanup fpga11107 code including this soon.

Thanks,
JD


      reply	other threads:[~2012-04-23 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23 12:43 Possible integer overflow in mach-bcmring with FPGA11107 Christian Dietrich
2012-04-23 20:19 ` Jiandong Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F95B951.6020700@broadcom.com \
    --to=jdzheng@broadcom.com \
    --cc=dietrich@cs.fau.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=sbranden@broadcom.com \
    --cc=vamos-dev@i4.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox