From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756168Ab2DXB2S (ORCPT ); Mon, 23 Apr 2012 21:28:18 -0400 Received: from oproxy1-pub.bluehost.com ([66.147.249.253]:38815 "HELO oproxy1-pub.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754420Ab2DXB2Q (ORCPT ); Mon, 23 Apr 2012 21:28:16 -0400 Message-ID: <4F9601CD.2070000@xenotime.net> Date: Mon, 23 Apr 2012 18:28:45 -0700 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110323 Thunderbird/3.1.9 MIME-Version: 1.0 To: "Eric W. Biederman" CC: David Miller , Stephen Rothwell , linux-next@vger.kernel.org, LKML , netdev@vger.kernel.org, linux-hams@vger.kernel.org, Ralf Baechle Subject: Re: [PATCH] net ax25: Fix the build when sysctl support is disabled. References: <20120423170701.c96e402234b1387dece11dda@canb.auug.org.au> <4F95828A.8050403@xenotime.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Identified-User: {1807:box742.bluehost.com:xenotime:xenotime.net} {sentby:smtp auth 50.53.38.135 authed with rdunlap@xenotime.net} Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/23/2012 05:25 PM, Eric W. Biederman wrote: > > Randy Dunlap reported: > >> On 04/23/2012 12:07 AM, Stephen Rothwell wrote: >> >>> Hi all, >>> >>> Changes since 20120420: >> >> >> include/net/ax25.h:447:75: error: expected ';' before '}' token >> >> static inline int ax25_register_dev_sysctl(ax25_dev *ax25_dev) { return 0 }; >> static inline void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev) {}; >> >> First function: move ';' inside braces. >> Second function: drop the ';'. > > Put the semicolons where it makes sense. > > Signed-off-by: Eric W. Biederman Acked-by: Randy Dunlap Thanks. > --- > > Resent to include David Miller. > > include/net/ax25.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/net/ax25.h b/include/net/ax25.h > index 8a7a122..5d23521 100644 > --- a/include/net/ax25.h > +++ b/include/net/ax25.h > @@ -444,8 +444,8 @@ extern void ax25_uid_free(void); > extern int ax25_register_dev_sysctl(ax25_dev *ax25_dev); > extern void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev); > #else > -static inline int ax25_register_dev_sysctl(ax25_dev *ax25_dev) { return 0 }; > -static inline void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev) {}; > +static inline int ax25_register_dev_sysctl(ax25_dev *ax25_dev) { return 0; } > +static inline void ax25_unregister_dev_sysctl(ax25_dev *ax25_dev) {} > #endif /* CONFIG_SYSCTL */ > > #endif -- ~Randy