Re: [PATCH] kernel: sys.c: Fixed coding style issues

Valentin Ilie
2012-04-21T15:27:59Z

> This kind of patch is not easy to review.
> Can you please prove that no logic has changed?
> E.g. By comparing the object file before and after your patch...

Everything seems to be OK.

The diff is because the old version had an unnecessary \n in two places.

$ checkpatch.pl -q --file --terse /tmp/test/sys.c | grep total
total: 33 errors, 18 warnings, 2057 lines checked
$ checkpatch.pl -q --file --terse /tmp/test/sys_patched.c | grep total
total: 4 errors, 14 warnings, 2055 lines checked

$ diff -iEbwB sys.c sys_patched.c
215,216c215
< else if ((who != cred->uid) &&
< !(user = find_user(who)))
---
> else if ((who != cred->uid) && !(user = find_user(who)))
280,281c279
< else if ((who != cred->uid) &&
< !(user = find_user(who)))
---
> else if ((who != cred->uid) && !(user = find_user(who)))

--
Valentin Ilie