Re: [PATCH] kernel: sys.c: Fixed coding style issues

Randy Dunlap
2012-04-21T22:36:17Z

On 04/21/2012 03:35 PM, Randy Dunlap wrote:

> On 04/21/2012 08:27 AM, Valentin Ilie wrote:
>
>>> This kind of patch is not easy to review.
>>> Can you please prove that no logic has changed?
>>> E.g. By comparing the object file before and after your patch...
>>
>> Everything seems to be OK.
>>
>> The diff is because the old version had an unnecessary \n in two places.
>
> But Richard asked you to compare the object files (binary files,
> kernel/sys.o) to make sure that they are the same.
>

and maybe you did that, but it's not clear that you did.

>
>> $ checkpatch.pl -q --file --terse /tmp/test/sys.c | grep total
>> total: 33 errors, 18 warnings, 2057 lines checked
>> $ checkpatch.pl -q --file --terse /tmp/test/sys_patched.c | grep total
>> total: 4 errors, 14 warnings, 2055 lines checked
>>
>> $ diff -iEbwB sys.c sys_patched.c
>> 215,216c215
>> < else if ((who != cred->uid) &&
>> < !(user = find_user(who)))
>> ---
>>> else if ((who != cred->uid) && !(user = find_user(who)))
>> 280,281c279
>> < else if ((who != cred->uid) &&
>> < !(user = find_user(who)))
>> ---
>>> else if ((who != cred->uid) && !(user = find_user(who)))
>>
>>
>
>
>

--
~Randy