From: Prarit Bhargava <prarit@redhat.com>
To: John Stultz <john.stultz@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Salman Qazi <sqazi@google.com>,
stable@kernel.org
Subject: Re: [PATCH] clocksource, prevent overflow in clocksource_cyc2ns
Date: Wed, 25 Apr 2012 08:29:58 -0400 [thread overview]
Message-ID: <4F97EE46.4070305@redhat.com> (raw)
In-Reply-To: <4F905576.6040406@linaro.org>
On 04/19/2012 02:12 PM, John Stultz wrote:
> On 04/19/2012 05:52 AM, Thomas Gleixner wrote:
>> On Thu, 19 Apr 2012, Thomas Gleixner wrote:
>>
>>> We should think about the reasons why we have interrupts disabled for
>>> so much time. Is that really, really necessary ?
>> I'm not against making the clocksource code more robust, but I don't
>> want to add crap there just to cope with complete madness elsewhere.
>>
>
> Very much agreed.
Hi John and Thomas,
After much analysis I have good news to report. The good news is that the
problem with the random tsc failures was chased down to a script left running in
which sysrq-t's were executed over ping packets. This, as I've previously
pointed out, can cause the tsc to be erroneously marked unstable.
[Aside: I hit myself with a big cluebat when I realized that all the failures
were occurring at the same wall-clock time, 3:00AM. That couldn't be a
coincidence.]
I'm working with lwoodman to figure out a way to get rid of the locking (as
suggested by you Thomas) around the sysrq code.
P.
> -john
>
next prev parent reply other threads:[~2012-04-25 12:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 15:11 [PATCH] clocksource, prevent overflow in clocksource_cyc2ns Prarit Bhargava
2012-04-04 18:00 ` John Stultz
2012-04-04 18:33 ` Prarit Bhargava
2012-04-05 1:08 ` John Stultz
2012-04-05 11:00 ` Prarit Bhargava
2012-04-05 16:23 ` John Stultz
2012-04-05 12:27 ` Prarit Bhargava
2012-04-05 16:45 ` John Stultz
2012-04-06 23:29 ` Thomas Gleixner
2012-04-07 13:47 ` Prarit Bhargava
2012-04-18 23:20 ` John Stultz
2012-04-18 23:59 ` Prarit Bhargava
2012-04-19 0:18 ` John Stultz
2012-04-19 11:56 ` Prarit Bhargava
2012-04-19 12:50 ` Thomas Gleixner
2012-04-19 12:52 ` Thomas Gleixner
2012-04-19 13:06 ` Prarit Bhargava
2012-04-19 13:18 ` Thomas Gleixner
2012-04-19 18:12 ` John Stultz
2012-04-25 12:29 ` Prarit Bhargava [this message]
2012-04-19 12:37 ` Thomas Gleixner
2012-04-19 12:51 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F97EE46.4070305@redhat.com \
--to=prarit@redhat.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sqazi@google.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox