From: Jason Wessel <jason.wessel@windriver.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@linux.intel.com>
Subject: Re: [PATCH] kgdb: Do not allow function tracing of kgdb code
Date: Wed, 25 Apr 2012 10:23:31 -0500 [thread overview]
Message-ID: <4F9816F3.8040302@windriver.com> (raw)
In-Reply-To: <1335367093.28106.165.camel@gandalf.stny.rr.com>
On 04/25/2012 10:18 AM, Steven Rostedt wrote:
> As function tracing the kgdb code can cause issues, as kgdb is a
> debugger itself, do not trace the kgdb functions.
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
> diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
> index 532d2e0..b7828ce 100644
> --- a/arch/x86/kernel/Makefile
> +++ b/arch/x86/kernel/Makefile
> @@ -15,6 +15,7 @@ CFLAGS_REMOVE_pvclock.o = -pg
> CFLAGS_REMOVE_kvmclock.o = -pg
> CFLAGS_REMOVE_ftrace.o = -pg
> CFLAGS_REMOVE_early_printk.o = -pg
> +CFLAGS_REMOVE_kgdb.o = -pg
> endif
>
> obj-y := process_$(BITS).o signal.o entry_$(BITS).o
>
>
Per our off mailing list discussion, I absolutely agree.
This came up in the course of looking through the new code proposed
around removing the stop machine for ftrace.
Acked-by: Jason Wessel <jason.wessel@windriver.com>
Cheers,
Jason.
prev parent reply other threads:[~2012-04-25 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 15:18 [PATCH] kgdb: Do not allow function tracing of kgdb code Steven Rostedt
2012-04-25 15:23 ` Jason Wessel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9816F3.8040302@windriver.com \
--to=jason.wessel@windriver.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox