From: John Crispin <blogic@openwrt.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] pinctrl: add error messages to pinmux_map_to_setting()
Date: Wed, 25 Apr 2012 20:06:01 +0200 [thread overview]
Message-ID: <4F983D09.7040905@openwrt.org> (raw)
In-Reply-To: <1335371657-24120-1-git-send-email-swarren@wwwdotorg.org>
On 25/04/12 18:34, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> pinmux_map_to_setting() detects a number of errors, but doesn't report
> any specifics to the user, making debugging those errors hard.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> John, Linus,
>
> This is mostly just FYI in case John wants to roll this into his error
> reporting patch - it's all the changes I made to any non-Tegra files when
> debugging my DT map data.
>
> drivers/pinctrl/pinmux.c | 38 ++++++++++++++++++++++++++++----------
> 1 files changed, 28 insertions(+), 10 deletions(-)
Hi Stephen,
I was just about to send my patch. However, I will first fold your
suggestions into it.
Thanks,
John
next prev parent reply other threads:[~2012-04-25 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 16:34 [PATCH] pinctrl: add error messages to pinmux_map_to_setting() Stephen Warren
2012-04-25 18:06 ` John Crispin [this message]
2012-04-26 9:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F983D09.7040905@openwrt.org \
--to=blogic@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox