public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Carsten Emde <C.Emde@osadl.org>
To: Michael Witten <mfwitten@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	David Airlie <airlied@linux.ie>,
	Thomas Gleixner <tglx@linutronix.de>,
	DRI <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] drivers-gpu-drm-allow-to-load-edid-firmware.patch
Date: Thu, 26 Apr 2012 00:46:39 +0200	[thread overview]
Message-ID: <4F987ECF.3070306@osadl.org> (raw)
In-Reply-To: <c2bca06f15de4d0f8e4f7973719c644a-mfwitten@gmail.com>

Michael,

> On Sun, 11 Mar 2012 22:23:22 +0100, Carsten Emde wrote:
>> On 03/11/2012 02:44 PM, Alan Cox wrote:
>>>> This patch allows to load an EDID data set via the firmware interface.
>>>> It contains data sets of frequently used screen resolutions (1024x768,
>>>> 1280x1024, 1680x1050 and 1920x1080). The requested EDID data are
>>>> specified as a module parameter of the drm_kms_helper module, e.g.
>>>> options drm_kms_helper edid_firmware=edid/1280x1024.bin or as kernel
>>>> command line parameter.
>>> What if the DRM layer and driver are compiled in. They'll come up as
>>> console before the file system so the firmware request will hang ?
>> Admittedly I did not try to compile the DRM layer and driver into the
>> kernel. However, I created an error condition by specifying a
>> non-existing EDID file. In this case, the function returns with error,
>> the mode count remains 0, and the system continues to run as if the
>> edid_firmware= parameter had not been specified.
> Unfortunately, as of at least last month, my system hangs when I try to
> use your feature (just as described by Alan Cox); the log shows that
> during the boot process, there is a one-minute hang:
>
>    [    0.175207] [drm] radeon: power management initialized
>    [   60.896507] [drm:edid_load] *ERROR* Requesting EDID firmware "edid/1920x1200.bin" failed (err=-2)
>
> Is there any way to make your feature smarter about its timing with
> relation to file system accessibility?
Sure.

Please copy your EDID data file to the directory "firmware/edid" of the 
kernel source tree, configure

CONFIG_EXTRA_FIRMWARE="edid/1920x1200.bin"
CONFIG_EXTRA_FIRMWARE_DIR="firmware"

and rebuild/reboot your kernel.

Does it work then?

	-Carsten.

  reply	other threads:[~2012-04-25 23:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-10 20:20 [PATCH 0/3] Provide workarounds to use DRM/KMS with broken graphics hardware Carsten Emde
2012-03-10 20:20 ` [PATCH 1/3] drivers-gpu-drm-allow-to-load-edid-firmware.patch Carsten Emde
2012-03-11 13:44   ` Alan Cox
2012-03-11 21:23     ` Carsten Emde
2012-04-25  2:30       ` Michael Witten
2012-04-25 22:46         ` Carsten Emde [this message]
2012-03-11 23:59     ` Carsten Emde
2012-03-12 17:14   ` Valdis.Kletnieks
2012-03-10 20:20 ` [PATCH 2/3] drivers-gpu-drm-add-disable-enable-connector.patch Carsten Emde
2012-03-11  7:20   ` Dave Airlie
2012-03-11 20:46     ` Carsten Emde
2012-03-10 20:20 ` [PATCH 3/3] drivers-gpu-drm-i915-invert-backlight-brightness Carsten Emde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F987ECF.3070306@osadl.org \
    --to=c.emde@osadl.org \
    --cc=airlied@linux.ie \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mfwitten@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox