From: "H. Peter Anvin" <hpa@zytor.com>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, mjt@tls.msk.ru,
linux-kernel@vger.kernel.org, autofs@vger.kernel.org,
raven@themaw.net, thomas@m3y3r.de, stable@kernel.org
Subject: Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error.
Date: Fri, 27 Apr 2012 13:45:18 -0700 [thread overview]
Message-ID: <4F9B055E.6030404@zytor.com> (raw)
In-Reply-To: <20120427.150849.187285510481819228.davem@davemloft.net>
On 04/27/2012 12:08 PM, David Miller wrote:
>>
>> Umm. The thing is, those broken binaries *work* on 32-bit. They were
>> *tested* on 32-bit. They were *shipped* on 32-bit.
>
> As were the automount binaries.
>
> systemd coded to an interface which did not exist in reality, and if
> they had used the automountd sources as a reference (the only other
> user of this interface) they would have seen this.
>
> Look, I can almost guarantee that whoever wrote the automountd
> workaround code looked at this situation and said "yeah, it's
> impossible to get this right in the kernel for all cases for v5, so
> let's just do it where we _can_ be absolutely certain and that's here
> in this userland routine doing the autofs stuff"
>
> And you know what, whoever that guy was, he was right.
The workaround in automount is a mistake too, though. The better
solution would have been to swallow the extra zero field; data driven.
-hpa
next prev parent reply other threads:[~2012-04-27 20:45 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 13:34 [PATCH v2] Introduce a version6 of autofs interface, to fix design error Michael Tokarev
2012-04-26 13:44 ` Michael Tokarev
2012-04-27 0:37 ` Linus Torvalds
2012-04-27 9:45 ` Michael Tokarev
2012-04-27 15:47 ` Mark Lord
2012-04-27 20:37 ` H. Peter Anvin
2012-04-28 22:20 ` Mark Lord
2012-04-27 16:22 ` David Miller
2012-04-27 17:10 ` Michael Tokarev
2012-04-27 17:28 ` David Miller
2012-04-27 18:19 ` Linus Torvalds
2012-04-27 18:34 ` David Miller
2012-04-27 18:42 ` Linus Torvalds
2012-04-27 18:55 ` Linus Torvalds
2012-04-27 19:14 ` David Miller
2012-04-27 19:16 ` David Miller
2012-04-27 19:19 ` Linus Torvalds
2012-04-27 19:24 ` David Miller
2012-04-27 19:56 ` Linus Torvalds
2012-04-27 20:13 ` Stef Bon
2012-04-27 20:29 ` David Miller
2012-04-27 22:40 ` Linus Torvalds
2012-04-27 20:43 ` H. Peter Anvin
2012-04-27 22:42 ` Linus Torvalds
2012-04-27 22:56 ` H. Peter Anvin
2012-04-27 23:07 ` Linus Torvalds
2012-04-28 0:03 ` H. Peter Anvin
2012-04-28 0:17 ` Linus Torvalds
2012-04-27 22:42 ` Alan Cox
2012-04-27 22:49 ` Linus Torvalds
2012-04-27 23:27 ` Linus Torvalds
2012-04-28 16:10 ` Linus Torvalds
2012-04-29 6:37 ` Michael Tokarev
2012-04-29 7:19 ` Linus Torvalds
2012-04-29 7:45 ` Michael Tokarev
2012-04-29 18:29 ` Linus Torvalds
2012-04-29 19:09 ` Linus Torvalds
2012-04-29 19:53 ` Michael Tokarev
2012-04-29 20:53 ` Linus Torvalds
2012-04-30 8:41 ` Thomas Meyer
2012-04-28 1:56 ` Ian Kent
2012-04-27 19:08 ` David Miller
2012-04-27 20:45 ` H. Peter Anvin [this message]
2012-04-27 20:42 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9B055E.6030404@zytor.com \
--to=hpa@zytor.com \
--cc=autofs@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=raven@themaw.net \
--cc=stable@kernel.org \
--cc=thomas@m3y3r.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox