From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761416Ab2D0Upx (ORCPT ); Fri, 27 Apr 2012 16:45:53 -0400 Received: from terminus.zytor.com ([198.137.202.10]:40286 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760645Ab2D0Upw (ORCPT ); Fri, 27 Apr 2012 16:45:52 -0400 Message-ID: <4F9B055E.6030404@zytor.com> Date: Fri, 27 Apr 2012 13:45:18 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: David Miller CC: torvalds@linux-foundation.org, mjt@tls.msk.ru, linux-kernel@vger.kernel.org, autofs@vger.kernel.org, raven@themaw.net, thomas@m3y3r.de, stable@kernel.org Subject: Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error. References: <20120427.143402.1028957981042061092.davem@davemloft.net> <20120427.150849.187285510481819228.davem@davemloft.net> In-Reply-To: <20120427.150849.187285510481819228.davem@davemloft.net> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/2012 12:08 PM, David Miller wrote: >> >> Umm. The thing is, those broken binaries *work* on 32-bit. They were >> *tested* on 32-bit. They were *shipped* on 32-bit. > > As were the automount binaries. > > systemd coded to an interface which did not exist in reality, and if > they had used the automountd sources as a reference (the only other > user of this interface) they would have seen this. > > Look, I can almost guarantee that whoever wrote the automountd > workaround code looked at this situation and said "yeah, it's > impossible to get this right in the kernel for all cases for v5, so > let's just do it where we _can_ be absolutely certain and that's here > in this userland routine doing the autofs stuff" > > And you know what, whoever that guy was, he was right. The workaround in automount is a mistake too, though. The better solution would have been to swallow the extra zero field; data driven. -hpa