From: Larry Finger <Larry.Finger@lwfinger.net>
To: Gabriel Paubert <paubert@iram.es>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Andreas Schwab <schwab@linux-m68k.org>,
linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tty/serial/pmac_zilog: Fix "nobody cared" IRQ message
Date: Sun, 29 Apr 2012 10:47:03 -0500 [thread overview]
Message-ID: <4F9D6277.9080402@lwfinger.net> (raw)
In-Reply-To: <20120429090520.GA26740@visitor2.iram.es>
On 04/29/2012 04:05 AM, Gabriel Paubert wrote:
> On Sat, Apr 28, 2012 at 06:53:49PM -0500, Larry Finger wrote:
>
> Hmm, I'm not a native english speaker, but I have the feeling that
> it would be more grammatically correct to use "opened" instead of "open".
>
> Of course if the message never triggers, it's less of concern :-)
English is my native language, but that might not help. :)
I would say "the device has not been opened", but "it is not open". More
generally, to me "opened" denotes past tense, and "open" is used in the present.
Even with the other bug, the message never triggered as I did not have debugging
enabled. Given the relative rarity of PPC-based boxes running Linux, the message
may never print.
Thanks for the comment.
Larry
next prev parent reply other threads:[~2012-04-29 15:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 23:53 [PATCH] tty/serial/pmac_zilog: Fix "nobody cared" IRQ message Larry Finger
2012-04-29 9:05 ` Gabriel Paubert
2012-04-29 15:47 ` Larry Finger [this message]
2012-04-30 0:23 ` Benjamin Herrenschmidt
2012-04-30 0:52 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9D6277.9080402@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paubert@iram.es \
--cc=paulus@samba.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox