Re: [PATCH v2] Introduce a version6 of autofs interface, to fix design error.

Thomas Meyer
2012-04-30T08:41:26Z

Am Sonntag, den 29.04.2012, 23:53 +0400 schrieb Michael Tokarev:
> On 29.04.2012 23:09, Linus Torvalds wrote:
> >
> > This keeps Alan's idea of using O_DIRECT, but only makes it matter for
> > the writer - because now the "packet" thing is a per-pipe-buffer state
> > (we already had per-pipe-buffer flags, so this is not anything new).
> > So when you *write* using a O_DIRECT pipe, it will create packetized
> > buffers, and the reader just sees that directly.
> >
> > So this should "just work", and doesn't need any extra flags in the
> > pipe_inode_info. And the user space interface remains the same: you
> > can create these packet pipes with "pipe2(fd, O_DIRECT)" if you want
> > to, and my test-program gives exactly the same output.
>
> Ok. I verified this on 3.3 kernel (with the original fix reverted),
> and now both autofs5 and systemd works.

hi,

I can also confirm that "autofs: make the autofsv5 packet file
descriptor use a packetized pipe" and "pipes: add a "packetized pipe"
mode for writing" on top of 3.3.4 works correctly at least with the
autofs feature of systemd.

And sorry for the delayed answer, but I've been away from the internet
for a few days.

and a big sorry for all the trouble...

with kind regards
thomas