From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756648Ab2D3UBN (ORCPT ); Mon, 30 Apr 2012 16:01:13 -0400 Received: from mailhost.informatik.uni-hamburg.de ([134.100.9.70]:53034 "EHLO mailhost.informatik.uni-hamburg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756227Ab2D3UBL (ORCPT ); Mon, 30 Apr 2012 16:01:11 -0400 Message-ID: <4F9EEFB2.8030201@metafoo.de> Date: Mon, 30 Apr 2012 22:01:54 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120207 Icedove/3.0.11 MIME-Version: 1.0 To: joseph daniel CC: Jonathan Cameron , Greg Kroah-Hartman , Wolfram Sang , Paul Gortmaker , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging/iio/meter: fix the coding style problem References: <1335813977-8096-1-git-send-email-josephdanielwalter@gmail.com> In-Reply-To: <1335813977-8096-1-git-send-email-josephdanielwalter@gmail.com> X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/30/2012 09:26 PM, joseph daniel wrote: > Signed-off-by: joseph daniel > --- > Hi Lars, > Thanks for review. how about the below change? > drivers/staging/iio/meter/ade7854-i2c.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c > index 1e1faa0..52bdb05 100644 > --- a/drivers/staging/iio/meter/ade7854-i2c.c > +++ b/drivers/staging/iio/meter/ade7854-i2c.c > @@ -181,6 +181,7 @@ static int ade7854_i2c_read_reg_32(struct device *dev, > { > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct ade7854_state *st = iio_priv(indio_dev); > + uint32_t value; > int ret; > > mutex_lock(&st->buf_lock); > @@ -195,7 +196,10 @@ static int ade7854_i2c_read_reg_32(struct device *dev, > if (ret) > goto out; > > - *val = (st->rx[0] << 24) | (st->rx[1] << 16) | (st->rx[2] << 8) | st->rx[3]; > + memcpy(&value, st->rx, sizeof(uint32_t)); > + Uhm, yes, you are right st->rx is unaligned. The memcpy is not necessary though if you use get_unaligned_be32. Sorry for the pointer to the wrong function. Btw. there are a few other locations in this driver which could use the put_unaligned_be* and get_unaligned_be* functions. Would be great if you could convert these as well. > + *val = be32_to_cpu(value); > + > out: > mutex_unlock(&st->buf_lock); > return ret;