[PATCH] [RESEND] Install kernel-page-flags.h

[PATCH] [RESEND] Install kernel-page-flags.h

[Ulrich Drepper]

No one has definitely commented on this patch nor is it applied.  Christoph at first said it shouldn't be done but I think he had to retract his objection.  The interface is already out there.  It's also IMO the right choice to go with a binary interface since there is so much data involved and the format is not tied directly to kernel-internal data structures.

Could either the patch please be applied or a reason given why not?


Signed-off-by: Ulrich Drepper <drepper@gmail.com>

 include/linux/Kbuild              |    1 +
 include/linux/kernel-page-flags.h |    4 ++++
 2 files changed, 5 insertions(+)

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 3c9b616..50f55c7 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -227,6 +227,7 @@
 header-y += kdev_t.h
 header-y += kernel.h
 header-y += kernelcapi.h
+header-y += kernel-page-flags.h
 header-y += keyboard.h
 header-y += keyctl.h
 header-y += l2tp.h
diff --git a/include/linux/kernel-page-flags.h b/include/linux/kernel-page-flags.h
index 26a6571..a1bdf69 100644
--- a/include/linux/kernel-page-flags.h
+++ b/include/linux/kernel-page-flags.h
@@ -32,6 +32,8 @@
 #define KPF_KSM			21
 #define KPF_THP			22
 
+#ifdef __KERNEL__
+
 /* kernel hacking assistances
  * WARNING: subject to change, never rely on them!
  */
@@ -44,4 +46,6 @@
 #define KPF_ARCH		38
 #define KPF_UNCACHED		39
 
+#endif /* __KERNEL__ */
+
 #endif /* LINUX_KERNEL_PAGE_FLAGS_H */

Re: [PATCH] [RESEND] Install kernel-page-flags.h

[KOSAKI Motohiro]

(4/29/12 10:04 AM), Ulrich Drepper wrote:
> No one has definitely commented on this patch nor is it applied.  Christoph at first said it shouldn't be done but I think he had to retract his objection.  The interface is already out there.  It's also IMO the right choice to go with a binary interface since there is so much data involved and the format is not tied directly to kernel-internal data structures.
> 
> Could either the patch please be applied or a reason given why not?
> 
> 
> Signed-off-by: Ulrich Drepper<drepper@gmail.com>
> 

linux/Documentation/vm/page-type.c has redundant definition of KPF_*. then, this exporting will solve it.
I'm going to ack if you can fix two things.
 1) your current changelog looks like a chat log style. Please write formal changelog.
 2) Please fix page-type.c too.

and pelase cc Wu Fengguang <fengguang.wu@intel.com>. His last commit explicitly says kernel-page-flags.h
was intentionally made for user space tools. see below.


commit 1a9b5b7fe0c5dad8a635288882d36785dea742f9
Author: Wu Fengguang <fengguang.wu@intel.com>
Date:   Wed Dec 16 12:19:59 2009 +0100

    mm: export stable page flags
    
    Rename get_uflags() to stable_page_flags() and make it a global function
    for use in the hwpoison page flags filter, which need to compare user
    page flags with the value provided by user space.
    
    Also move KPF_* to kernel-page-flags.h for use by user space tools.
    
    Acked-by: Matt Mackall <mpm@selenic.com>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    CC: Nick Piggin <npiggin@suse.de>
    CC: Christoph Lameter <cl@linux-foundation.org>
    Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

Re: [PATCH] [RESEND] Install kernel-page-flags.h

[Ulrich Drepper]

On Tue, May 1, 2012 at 8:09 PM, KOSAKI Motohiro
<kosaki.motohiro@gmail.com> wrote:
> I'm going to ack if you can fix two things.
>  1) your current changelog looks like a chat log style. Please write formal changelog.
>  2) Please fix page-type.c too.

OK, done.

I've also sent a second patch to clean up page-type.c to compile more
cleanly with recent compilers.  One more set of patches needed to
clean it up completely.