From: Mike Christie <michaelc@cs.wisc.edu>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, vgoyal@redhat.com, ctalbott@google.com,
rni@google.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, containers@lists.linux-foundation.org,
fengguang.wu@intel.com, hughd@google.com,
akpm@linux-foundation.org,
James Bottomley <James.Bottomley@HansenPartnership.com>,
James Smart <james.smart@emulex.com>
Subject: Re: [PATCH 05/11] block: drop custom queue draining used by scsi_transport_{iscsi|fc}
Date: Tue, 01 May 2012 23:55:49 -0500 [thread overview]
Message-ID: <4FA0BE55.2000305@cs.wisc.edu> (raw)
In-Reply-To: <1335477561-11131-6-git-send-email-tj@kernel.org>
On 04/26/2012 04:59 PM, Tejun Heo wrote:
> iscsi_remove_host() uses bsg_remove_queue() which implements custom
> queue draining. fc_bsg_remove() open-codes mostly identical logic.
>
> The draining logic isn't correct in that blk_stop_queue() doesn't
> prevent new requests from being queued - it just stops processing, so
> nothing prevents new requests to be queued after the logic determines
> that the queue is drained.
>
> blk_cleanup_queue() now implements proper queue draining and these
> custom draining logics aren't necessary. Drop them and use
> bsg_unregister_queue() + blk_cleanup_queue() instead.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: Mike Christie <michaelc@cs.wisc.edu>
> Cc: James Smart <james.smart@emulex.com>
> ---
> block/bsg-lib.c | 53 -----------------------------------
> drivers/scsi/scsi_transport_fc.c | 38 -------------------------
> drivers/scsi/scsi_transport_iscsi.c | 2 +-
iSCSI changes worked ok for me. I replicated the problem that the old
code was supposed to fix and verified the new code worked ok. I also
tested the FC code briefly (I do not have a proper setup to really
stress it), and it worked ok.
Thanks for killing that code for us.
Reviewed-by: Mike Christie <michaelc@.cs.wisc.edu>
next prev parent reply other threads:[~2012-05-02 4:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 21:59 [PATCHSET] block: implement per-blkg request allocation Tejun Heo
2012-04-26 21:59 ` [PATCH 01/11] blkcg: fix blkg_alloc() failure path Tejun Heo
2012-04-27 14:26 ` Vivek Goyal
2012-04-27 14:27 ` Tejun Heo
2012-04-26 21:59 ` [PATCH 02/11] blkcg: __blkg_lookup_create() doesn't have to fail on radix tree preload failure Tejun Heo
2012-04-27 14:42 ` Vivek Goyal
2012-04-27 14:47 ` Tejun Heo
2012-04-27 21:18 ` [PATCH UPDATED 02/11] blkcg: __blkg_lookup_create() doesn't need radix preload Tejun Heo
2012-04-26 21:59 ` [PATCH 03/11] blkcg: make root blkcg allocation use %GFP_KERNEL Tejun Heo
2012-04-27 21:19 ` [PATCH UPDATED " Tejun Heo
2012-04-26 21:59 ` [PATCH 04/11] mempool: add @gfp_mask to mempool_create_node() Tejun Heo
2012-04-26 21:59 ` [PATCH 05/11] block: drop custom queue draining used by scsi_transport_{iscsi|fc} Tejun Heo
2012-05-02 4:55 ` Mike Christie [this message]
2012-04-26 21:59 ` [PATCH 06/11] block: refactor get_request[_wait]() Tejun Heo
2012-04-26 21:59 ` [PATCH 07/11] block: allocate io_context upfront Tejun Heo
2012-04-26 21:59 ` [PATCH 08/11] blkcg: inline bio_blkcg() and friends Tejun Heo
2012-04-26 21:59 ` [PATCH 09/11] block: add q->nr_rqs[] and move q->rq.elvpriv to q->nr_rqs_elvpriv Tejun Heo
2012-04-26 21:59 ` [PATCH 10/11] block: prepare for multiple request_lists Tejun Heo
2012-04-26 21:59 ` [PATCH 11/11] blkcg: implement per-blkg request allocation Tejun Heo
2012-04-27 14:54 ` Jeff Moyer
2012-04-27 15:02 ` Tejun Heo
2012-04-27 15:40 ` Vivek Goyal
2012-04-27 15:45 ` Tejun Heo
2012-04-27 15:48 ` Vivek Goyal
2012-04-27 15:51 ` Tejun Heo
2012-04-27 15:56 ` Vivek Goyal
2012-04-27 16:19 ` Vivek Goyal
2012-04-27 16:20 ` Tejun Heo
2012-04-27 17:21 ` Vivek Goyal
2012-04-27 17:25 ` Tejun Heo
2012-04-27 19:46 ` Vivek Goyal
2012-04-27 20:15 ` Tejun Heo
2012-04-27 20:21 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA0BE55.2000305@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=ctalbott@google.com \
--cc=fengguang.wu@intel.com \
--cc=hughd@google.com \
--cc=james.smart@emulex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rni@google.com \
--cc=tj@kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox