public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
	npiggin@gmail.com, jana@saout.de, jlbec@evilplan.org,
	linux-kernel@vger.kernel.org
Subject: Re: Oops with DCACHE_WORD_ACCESS and ocfs2, autofs4
Date: Thu, 03 May 2012 14:23:53 -0700	[thread overview]
Message-ID: <4FA2F769.40903@zytor.com> (raw)
In-Reply-To: <20120503.144844.988487177633544388.davem@davemloft.net>

On 05/03/2012 11:48 AM, David Miller wrote:
> From: "H. Peter Anvin" <hpa@zytor.com>
> Date: Thu, 03 May 2012 11:28:44 -0700
> 
>> +		"lea" __WORDSUFFIX " %2,%1\n\t"
>> +		"and" __WORDSUFFIX " %4,%1\n\t"
>> +		"shl" __WORDSUFFIX " $3,%1\n\t"
>> +		"shr" __WORDSUFFIX " %b1,%0\n\t"
>>
>> Also, for this sequence of instructions using %ecx unconditionally is
>> actually better (avoids REX prefixes on 64 bits.)
> 
> If it doesn't exist already, someone should really add bits to
> binutils so you guys don't have to string paste like this.
> 
> For example a bit a mnenomics that the assembler internally changes
> into the 64-bit or 32-bit variant based upon what bitness it is
> targetting.
> 
> We have these on sparc, for example "ldn" is transformed into "lduw"
> for 32-bit and "ldx" for 64-bit.

I don't think we really need it.  For the vast majority of all
instructions the size is given by the operands, and for the balance we
can generally use %z and/or <asm/asm.h>.  %z would be more useful if
there wasn't for the fact that some now quite old versions of gcc
incorrectly produce "ll" instead of "q".

	-hpa


  reply	other threads:[~2012-05-03 21:24 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30 12:27 Oops with DCACHE_WORD_ACCESS and ocfs2, autofs4 Jana Saout
2012-05-01 11:00 ` Joel Becker
2012-05-01 12:28   ` Jana Saout
2012-05-03  5:02     ` Nick Piggin
2012-05-03  5:57       ` Linus Torvalds
2012-05-03  5:57         ` Linus Torvalds
2012-05-03  6:23         ` Nick Piggin
2012-05-03  6:26           ` Nick Piggin
2012-05-03  6:38         ` H. Peter Anvin
2012-05-03  6:40           ` H. Peter Anvin
2012-05-03  6:54           ` David Miller
2012-05-03  6:57             ` H. Peter Anvin
2012-05-03  7:02               ` David Miller
2012-05-03  6:47         ` Al Viro
2012-05-03 16:15           ` Linus Torvalds
2012-05-03 17:30             ` Al Viro
2012-05-03 17:30             ` Linus Torvalds
2012-05-03 18:13               ` H. Peter Anvin
2012-05-03 18:23                 ` Linus Torvalds
2012-05-03 18:27                   ` H. Peter Anvin
2012-05-03 18:28                   ` H. Peter Anvin
2012-05-03 18:48                     ` David Miller
2012-05-03 21:23                       ` H. Peter Anvin [this message]
2012-05-03 19:06                     ` Linus Torvalds
2012-05-03 20:30                   ` Jana Saout
2012-05-03 21:01                     ` Linus Torvalds
2012-05-03 21:03                     ` Jana Saout
2012-05-03 21:20                       ` Linus Torvalds
2012-05-03 21:47                         ` Jana Saout
2012-05-04 11:21                         ` Jana Saout
2012-05-03  8:01         ` Jana Saout

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA2F769.40903@zytor.com \
    --to=hpa@zytor.com \
    --cc=davem@davemloft.net \
    --cc=jana@saout.de \
    --cc=jlbec@evilplan.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox