linux-next: build failure after merge of the final tree (kbuild tree related)

linux-next: build failure after merge of the final tree (kbuild tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

scripts/kconfig/conf --allnoconfig Kconfig
*** KCONFIG_ALLCONFIG set, but no "allno.config" or "all.config" file found

I did not have KCONFIG_ALLCONFIG set in the environment and was building
with an external object directory ...

Presumably caused by commit 5efe241eac80 ("kconfig: Add error handling to
KCONFIG_ALLCONFIG").  I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

[PATCH] kbuild: all{no,yes,mod,def,rand}config only read files when instructed to.

[Eric W. Biederman]

Prevent subtle surprises to both people working on the kconfig code
and people using make allnoconfig allyesconfig allmoconfig and
randconfig by only attempting to read a config file if
KCONFIG_ALLCONFIG is set.

Common sense suggests attempting to read the extra config files does
not make sense unless requested.  The documentation says the code
won't attempt to read the extra config files unless requested.
Current usage does not appear to include people depending on the code
reading the config files without the variable being set So do the
simple thing and stop reading config files when passed
all{no,yes,mod,def,rand}config unless KCONFIG_ALLCONFIG environment
variable is set.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---
 scripts/kconfig/conf.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 0fdda91..0dc4a2c 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -574,7 +574,9 @@ int main(int ac, char **av)
 	case alldefconfig:
 	case randconfig:
 		name = getenv("KCONFIG_ALLCONFIG");
-		if (name && (strcmp(name, "") != 0) && (strcmp(name, "1") != 0)) {
+		if (!name)
+			break;
+		if ((strcmp(name, "") != 0) && (strcmp(name, "1") != 0)) {
 			if (conf_read_simple(name, S_DEF_USER)) {
 				fprintf(stderr,
 					_("*** Can't read seed configuration \"%s\"!\n"),
-- 
1.7.2.5

Re: [PATCH] kbuild: all{no,yes,mod,def,rand}config only read files when instructed to.

[Michal Marek]

Dne 7.5.2012 14:37, Eric W. Biederman napsal(a):
> 
> Prevent subtle surprises to both people working on the kconfig code
> and people using make allnoconfig allyesconfig allmoconfig and
> randconfig by only attempting to read a config file if
> KCONFIG_ALLCONFIG is set.
> 
> Common sense suggests attempting to read the extra config files does
> not make sense unless requested.  The documentation says the code
> won't attempt to read the extra config files unless requested.
> Current usage does not appear to include people depending on the code
> reading the config files without the variable being set

It's true that this bug/feature has been there since the introduction of
KCONFIG_ALLCONFIG, but I doubt anyone relies on it.


> So do the
> simple thing and stop reading config files when passed
> all{no,yes,mod,def,rand}config unless KCONFIG_ALLCONFIG environment
> variable is set.

Yes! I applied to kbuild.git#kconfig, with Reported-by: Stephen. Thanks
to both of you.

Michal