public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Shi <alex.shi@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Borislav Petkov <bp@amd64.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	mgorman@suse.de, npiggin@gmail.com, tglx@linutronix.de,
	mingo@redhat.com, arnd@arndb.de, rostedt@goodmis.org,
	fweisbec@gmail.com, jeremy@goop.org, gregkh@linuxfoundation.org,
	glommer@redhat.com, riel@redhat.com, luto@mit.edu,
	avi@redhat.com, len.brown@intel.com, dhowells@redhat.com,
	fenghua.yu@intel.com, yinghai@kernel.org, ak@linux.intel.com,
	cpw@sgi.com, steiner@sgi.com, akpm@linux-foundation.org,
	penberg@kernel.org, hughd@google.com, rientjes@google.com,
	kosaki.motohiro@jp.fujitsu.com, n-horiguchi@ah.jp.nec.com,
	paul.gortmaker@windriver.com, trenn@suse.de, tj@kernel.org,
	oleg@redhat.com, axboe@kernel.dk, kamezawa.hiroyu@jp.fujitsu.com,
	viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 7/7] x86/tlb: add tlb_flushall_factor into sysfs for user change
Date: Wed, 09 May 2012 13:03:56 +0800	[thread overview]
Message-ID: <4FA9FABC.9020900@intel.com> (raw)
In-Reply-To: <4FA94051.3000307@zytor.com>

On 05/08/2012 11:48 PM, H. Peter Anvin wrote:

> On 05/08/2012 08:41 AM, Borislav Petkov wrote:
>> On Tue, May 08, 2012 at 08:31:53AM -0700, H. Peter Anvin wrote:
>>> On 05/08/2012 08:25 AM, Borislav Petkov wrote:
>>>>
>>>> Yep, this was supposed to be for pinpointing the proper entries count.
>>>> I believe we don't have this thing of having code intree but not really
>>>> intree - only for testing new silicon. Maybe a debug module or add this
>>>> to debugfs?
>>>>
>>>
>>> We have a lot of that kind of code, it is usually hidden under
>>> CONFIG_*DEBUG* something.
>>
>> Then maybe this is where this knob should go, along with adding it to
>> debugfs instead of sysfs...
>>
> 
> I don't see a problem with it in sysfs.
> 


Ok. I will modify it according to comments.

  parent reply	other threads:[~2012-05-09  5:05 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 14:03 [PATCH v3] TLB flush optimization Alex Shi
2012-05-08 14:03 ` [PATCH v3 1/7] x86/tlb_info: get last level TLB entry number of CPU Alex Shi
2012-05-08 14:03 ` [PATCH v3 2/7] x86/flush_tlb: try flush_tlb_single one by one in flush_tlb_range Alex Shi
2012-05-08 14:03 ` [PATCH v3 3/7] x86/tlb: fall back to flush all when meet a THP large page Alex Shi
2012-05-08 14:03 ` [PATCH v3 4/7] x86/tlb: add tlb flush all factor for specific CPUs Alex Shi
2012-05-08 15:08   ` Peter Zijlstra
2012-05-09  2:03     ` Alex Shi
2012-05-08 15:12   ` H. Peter Anvin
2012-05-09  2:10     ` Alex Shi
2012-05-08 15:15   ` H. Peter Anvin
2012-05-08 15:56     ` Andi Kleen
2012-05-08 16:40       ` H. Peter Anvin
2012-05-08 15:18   ` H. Peter Anvin
2012-05-09  1:41     ` Alex Shi
2012-05-08 14:03 ` [PATCH v3 5/7] x86/tlb: remove comments for tlb_flush_range implement suggestion Alex Shi
2012-05-09  8:22   ` Nick Piggin
2012-05-08 14:03 ` [PATCH v3 6/7] x86/tlb: optimizing flush_tlb_mm Alex Shi
2012-05-08 15:09   ` Peter Zijlstra
2012-05-08 14:03 ` [PATCH v3 7/7] x86/tlb: add tlb_flushall_factor into sysfs for user change Alex Shi
2012-05-08 15:11   ` Peter Zijlstra
2012-05-08 15:20     ` H. Peter Anvin
2012-05-08 15:25       ` Borislav Petkov
2012-05-08 15:31         ` H. Peter Anvin
2012-05-08 15:41           ` Borislav Petkov
2012-05-08 15:48             ` H. Peter Anvin
2012-05-08 16:10               ` Greg KH
2012-05-08 16:28                 ` Borislav Petkov
2012-05-09  5:03               ` Alex Shi [this message]
2012-05-08 15:01 ` [PATCH v3] TLB flush optimization Peter Zijlstra
2012-05-09  1:58   ` Alex Shi
2012-05-09 23:45   ` Andi Kleen
2012-05-10  5:06     ` Alex Shi
2012-05-10  7:49     ` HATAYAMA Daisuke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA9FABC.9020900@intel.com \
    --to=alex.shi@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=avi@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bp@amd64.org \
    --cc=cpw@sgi.com \
    --cc=dhowells@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=glommer@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=hughd@google.com \
    --cc=jeremy@goop.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=npiggin@gmail.com \
    --cc=oleg@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=penberg@kernel.org \
    --cc=riel@redhat.com \
    --cc=rientjes@google.com \
    --cc=rostedt@goodmis.org \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=trenn@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox