Re: [PATCH V2 2/2] dmaengine: tegra: add dma driver

Laxman Dewangan
2012-05-11T11:02:33Z

On Friday 11 May 2012 02:11 PM, Vinod Koul wrote:
> On Thu, 2012-05-10 at 10:35 +0530, Laxman Dewangan wrote:
>
>> But when we update the chan->completed_cookie for aborted cookie?
>> Otherwise I will get the DMA_IN_PROGRSS when I call dma_cookie_status()
>> but actually it is aborted.
> no in .device_tx_status, you should check if the descriptor is aborted
> or not and rteurn error for aborted descriptor.
>
OK, I will not call this function.
Also I am dropping the ONCE_NOTIFY_HALF and will add later if require. I
realize that patch patch should be simple and sufficient so that other
driver development/upstream can be unblock. Later on we can add feature
based on necessary.

I am sending the new patch with considering all your feedback.
Thanks again for review.

Thanks,
Laxman