Re: [PATCH V2 1/2] dma: dmaengine: add slave req id in slave_config

Vinod Koul
2012-05-09T08:56:06Z

On Thu, 2012-05-03 at 13:11 +0530, Laxman Dewangan wrote:
> The dma controller like Nvidia's Tegra Dma controller
> supports the different slave requestor id from different slave.
> This need to be configure in dma controller to handle the request
> properly.
>
> Adding the slave-id in the slave configuration so that information
> can be passed from client when configuring for slave.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>
> This change is require to get rid of tegra_dma header to pass the
> slave requestor id.
>
> include/linux/dmaengine.h | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 1082698..b0b275f 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -338,6 +338,9 @@ enum dma_slave_buswidth {
> * @device_fc: Flow Controller Settings. Only valid for slave channels. Fill
> * with 'true' if peripheral should be flow controller. Direction will be
> * selected at Runtime.
> + * @slave_id: Slave requester id. Only valid for slave channels. The dma
> + * slave peripheral will have unique id as dma requester which need to be
> + * pass as slave config.
> *
> * This struct is passed in as configuration data to a DMA engine
> * in order to set up a certain channel for DMA transport at runtime.
> @@ -365,6 +368,7 @@ struct dma_slave_config {
> u32 src_maxburst;
> u32 dst_maxburst;
> bool device_fc;
> + int slave_id;
This wont be negative, so perhaps an unsigned value?
> };
>
> static inline const char *dma_chan_name(struct dma_chan *chan)

--
~Vinod