From: Markus Franke <markus.franke@s2002.tu-chemnitz.de>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Greg KH <greg@kroah.com>,
Markus Franke <markus.franke@s2002.tu-chemnitz.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100
Date: Wed, 09 May 2012 22:37:24 +0200 [thread overview]
Message-ID: <4FAAD584.70102@hrz.tu-chemnitz.de> (raw)
In-Reply-To: <20120503180056.GB13988@ioremap.net>
Dear Evgeniy,
I have reworked the patch and now I am not getting any checkpatch
warnings or errors anymore.
How about the binary sysfs files? If I understand correctly I would add
a documentation file under Documentation/w1/slaves which documents both
sysfs files (eeprom & pio).
@Greg: Could you live with those driver specific binary sysfs files?
Best regards,
Markus Franke
Am 03.05.2012 20:00, schrieb Evgeniy Polyakov:
> On Wed, May 02, 2012 at 01:21:34PM -0700, Greg KH (greg@kroah.com) wrote:
>>> Well, I just stuck to the way things are done in already existing
>>> drivers e.g. drivers/w1/slaves/w1_ds2433.c
>>
>> Really? Ick, where are those files documented?
>
> I'm kinda lost here.
>
> To clarify things a bit - w1 allows to create 'private' sysfs files for
> special functionality which exists only in given driver - like
> enable/disable checksum and so on. It has to be documented and must
> follow common kernel codying standards of course.
>
next prev parent reply other threads:[~2012-05-09 20:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 2:13 [PATCH] w1: Add 1-wire slave device driver for DS28E04-100 Greg KH
2012-05-02 20:12 ` Markus Franke
2012-05-02 20:21 ` Greg KH
2012-05-03 18:00 ` Evgeniy Polyakov
2012-05-09 20:37 ` Markus Franke [this message]
2012-05-09 22:06 ` Greg KH
2012-05-09 22:16 ` Markus Franke
2012-05-09 22:24 ` Greg KH
2012-05-09 22:37 ` Markus Franke
2012-05-09 23:57 ` Evgeniy Polyakov
2012-05-10 0:01 ` Greg KH
2012-05-10 0:43 ` Evgeniy Polyakov
2012-05-10 3:43 ` Greg KH
2012-05-10 4:55 ` Markus Franke
2012-05-10 15:16 ` Greg KH
2012-05-10 22:57 ` Markus Franke
2012-05-10 23:04 ` Greg KH
2012-05-11 6:13 ` Markus Franke
2012-05-15 1:21 ` Evgeniy Polyakov
2012-05-25 22:45 ` Markus Franke
2012-05-10 23:22 ` Andrew Morton
2012-05-11 6:15 ` Markus Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAAD584.70102@hrz.tu-chemnitz.de \
--to=markus.franke@s2002.tu-chemnitz.de \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox