From: Markus Franke <markus.franke@s2002.tu-chemnitz.de>
To: Greg KH <greg@kroah.com>
Cc: Markus Franke <markus.franke@s2002.tu-chemnitz.de>,
Evgeniy Polyakov <zbr@ioremap.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w1: Add 1-wire slave device driver for DS28E04-100
Date: Thu, 10 May 2012 00:16:23 +0200 [thread overview]
Message-ID: <4FAAECB7.8070904@hrz.tu-chemnitz.de> (raw)
In-Reply-To: <20120509220636.GA27659@kroah.com>
Dear Greg,
the file "pio" is used for reading the current PIO state of the
DS28E04-100. The "eeprom" file is for reading/writing the EEPROM memory
of the same device.
As already mentioned before this is exactly the way how other w1 slave
drivers are handling stuff like this. I could also wrap everything
within a character device driver if this the way you would prefer. If
not, then please give me some advise how to exchange these couple of
bytes between user and kernel space.
Best regards,
Markus Franke
Am 10.05.2012 00:06, schrieb Greg KH:
> On Wed, May 09, 2012 at 10:37:24PM +0200, Markus Franke wrote:
>> Dear Evgeniy,
>>
>> I have reworked the patch and now I am not getting any checkpatch
>> warnings or errors anymore.
>>
>> How about the binary sysfs files? If I understand correctly I would add
>> a documentation file under Documentation/w1/slaves which documents both
>> sysfs files (eeprom & pio).
>>
>> @Greg: Could you live with those driver specific binary sysfs files?
>
> Why do you need them? What are they there for?
>
> greg k-h
>
next prev parent reply other threads:[~2012-05-09 22:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 2:13 [PATCH] w1: Add 1-wire slave device driver for DS28E04-100 Greg KH
2012-05-02 20:12 ` Markus Franke
2012-05-02 20:21 ` Greg KH
2012-05-03 18:00 ` Evgeniy Polyakov
2012-05-09 20:37 ` Markus Franke
2012-05-09 22:06 ` Greg KH
2012-05-09 22:16 ` Markus Franke [this message]
2012-05-09 22:24 ` Greg KH
2012-05-09 22:37 ` Markus Franke
2012-05-09 23:57 ` Evgeniy Polyakov
2012-05-10 0:01 ` Greg KH
2012-05-10 0:43 ` Evgeniy Polyakov
2012-05-10 3:43 ` Greg KH
2012-05-10 4:55 ` Markus Franke
2012-05-10 15:16 ` Greg KH
2012-05-10 22:57 ` Markus Franke
2012-05-10 23:04 ` Greg KH
2012-05-11 6:13 ` Markus Franke
2012-05-15 1:21 ` Evgeniy Polyakov
2012-05-25 22:45 ` Markus Franke
2012-05-10 23:22 ` Andrew Morton
2012-05-11 6:15 ` Markus Franke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAAECB7.8070904@hrz.tu-chemnitz.de \
--to=markus.franke@s2002.tu-chemnitz.de \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox