From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-fbdev@vger.kernel.org, agust@denx.de
Subject: Re: [PATCH] video: mb862xxfbdrv.c: local functions should not be exposed globally
Date: Thu, 10 May 2012 00:12:33 +0000 [thread overview]
Message-ID: <4FAB07F1.4010900@gmx.de> (raw)
In-Reply-To: <201205021737.35719.hartleys@visionengravers.com>
On 05/03/2012 12:37 AM, H Hartley Sweeten wrote:
> Functions not referenced outside of a source file should be marked
> static to prevent them from being exposed globally.
>
> Quiets the sparse warnings:
>
> warning: symbol 'mb862xx_intr' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
> Cc: Anatolij Gustschin <agust@denx.de>
Applied.
Thanks,
Florian Tobias Schandinat
>
> ---
>
> diff --git a/drivers/video/mb862xx/mb862xxfbdrv.c b/drivers/video/mb862xx/mb862xxfbdrv.c
> index 11a7a33..00ce1f3 100644
> --- a/drivers/video/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/mb862xx/mb862xxfbdrv.c
> @@ -579,7 +579,7 @@ static ssize_t mb862xxfb_show_dispregs(struct device *dev,
>
> static DEVICE_ATTR(dispregs, 0444, mb862xxfb_show_dispregs, NULL);
>
> -irqreturn_t mb862xx_intr(int irq, void *dev_id)
> +static irqreturn_t mb862xx_intr(int irq, void *dev_id)
> {
> struct mb862xxfb_par *par = (struct mb862xxfb_par *) dev_id;
> unsigned long reg_ist, mask;
>
prev parent reply other threads:[~2012-05-10 0:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 0:37 [PATCH] video: mb862xxfbdrv.c: local functions should not be exposed globally H Hartley Sweeten
2012-05-10 0:12 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAB07F1.4010900@gmx.de \
--to=florianschandinat@gmx.de \
--cc=agust@denx.de \
--cc=hartleys@visionengravers.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox