* [PATCH 0/2] mfd: MAX8997: Support irq domain for Maxim MAX8997
@ 2012-05-10 10:54 Chanwoo Choi
2012-05-10 18:20 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Chanwoo Choi @ 2012-05-10 10:54 UTC (permalink / raw)
To: gregkh, broonie, thomas.abraham
Cc: myungjoo.ham, kyungmin.park, jonghwa3.lee, linux-kernel,
Chanwoo Choi
This patchset add support irq domain for Maxim MAX8997 interrupts.
The first patch is based on patch written by Thomas Abraham and fix
two bug which set max8997->irq_domain instead of NULL pointer and
correct wrong parameter by Chanwoo Choi.
- https://lkml.org/lkml/2012/4/18/145
The second patch use irq domain for MAX8997 muic interrupt instead
of irq_base in platform data of MAX8997 driver.
But, I posted following patchset related to MAX8997 driver.
This patchset support Extcon framework in extcon-max8997 driver to
control external connector instead of max8997-muic driver. So, first
patch add MAX8997 extcon driver(drivers/extcon/extcon-max8997.c) and
last patch remove old MAX8997 muic driver(drivers/misc/max8997-muic.c).
- https://lkml.org/lkml/2012/5/8/98
This patchset was applied in below git repository of Greg Kroah-Hartman.
- http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=shortlog;h=refs/heads/driver-core-next
I think that this patchset should be applied on the git repository
of Greg Kroah-Hartman to remove possible conflict issue when merged.
Chanwoo Choi (1):
Extcon: MAX8997: Add support irq domain for MAX8997 muic
Thomas Abraham (1):
mfd: add irq domain support for max8997 interrupts
arch/arm/mach-exynos/mach-nuri.c | 4 --
arch/arm/mach-exynos/mach-origen.c | 1 -
drivers/extcon/extcon-max8997.c | 26 +++++++++------
drivers/mfd/max8997-irq.c | 62 +++++++++++++++++++++--------------
drivers/mfd/max8997.c | 1 -
include/linux/mfd/max8997-private.h | 4 ++-
include/linux/mfd/max8997.h | 1 -
7 files changed, 56 insertions(+), 43 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] mfd: MAX8997: Support irq domain for Maxim MAX8997
2012-05-10 10:54 [PATCH 0/2] mfd: MAX8997: Support irq domain for Maxim MAX8997 Chanwoo Choi
@ 2012-05-10 18:20 ` Greg KH
2012-05-10 23:45 ` Chanwoo Choi
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2012-05-10 18:20 UTC (permalink / raw)
To: Chanwoo Choi
Cc: broonie, thomas.abraham, myungjoo.ham, kyungmin.park,
jonghwa3.lee, linux-kernel
On Thu, May 10, 2012 at 07:54:48PM +0900, Chanwoo Choi wrote:
> This patchset add support irq domain for Maxim MAX8997 interrupts.
>
> The first patch is based on patch written by Thomas Abraham and fix
> two bug which set max8997->irq_domain instead of NULL pointer and
> correct wrong parameter by Chanwoo Choi.
> - https://lkml.org/lkml/2012/4/18/145
> The second patch use irq domain for MAX8997 muic interrupt instead
> of irq_base in platform data of MAX8997 driver.
>
> But, I posted following patchset related to MAX8997 driver.
> This patchset support Extcon framework in extcon-max8997 driver to
> control external connector instead of max8997-muic driver. So, first
> patch add MAX8997 extcon driver(drivers/extcon/extcon-max8997.c) and
> last patch remove old MAX8997 muic driver(drivers/misc/max8997-muic.c).
> - https://lkml.org/lkml/2012/5/8/98
>
> This patchset was applied in below git repository of Greg Kroah-Hartman.
> - http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=shortlog;h=refs/heads/driver-core-next
>
> I think that this patchset should be applied on the git repository
> of Greg Kroah-Hartman to remove possible conflict issue when merged.
That's fine with me, should the MFD maintainer have been copied on this
to get his signed-off-by on it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] mfd: MAX8997: Support irq domain for Maxim MAX8997
2012-05-10 18:20 ` Greg KH
@ 2012-05-10 23:45 ` Chanwoo Choi
2012-05-10 23:52 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Chanwoo Choi @ 2012-05-10 23:45 UTC (permalink / raw)
To: Greg KH
Cc: broonie, thomas.abraham, myungjoo.ham, kyungmin.park,
jonghwa3.lee, linux-kernel, sameo@linux.intel.com
On 05/11/2012 03:20 AM, Greg KH wrote:
> On Thu, May 10, 2012 at 07:54:48PM +0900, Chanwoo Choi wrote:
>> This patchset add support irq domain for Maxim MAX8997 interrupts.
>>
>> The first patch is based on patch written by Thomas Abraham and fix
>> two bug which set max8997->irq_domain instead of NULL pointer and
>> correct wrong parameter by Chanwoo Choi.
>> - https://lkml.org/lkml/2012/4/18/145
>> The second patch use irq domain for MAX8997 muic interrupt instead
>> of irq_base in platform data of MAX8997 driver.
>>
>> But, I posted following patchset related to MAX8997 driver.
>> This patchset support Extcon framework in extcon-max8997 driver to
>> control external connector instead of max8997-muic driver. So, first
>> patch add MAX8997 extcon driver(drivers/extcon/extcon-max8997.c) and
>> last patch remove old MAX8997 muic driver(drivers/misc/max8997-muic.c).
>> - https://lkml.org/lkml/2012/5/8/98
>>
>> This patchset was applied in below git repository of Greg Kroah-Hartman.
>> - http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=shortlog;h=refs/heads/driver-core-next
>>
>> I think that this patchset should be applied on the git repository
>> of Greg Kroah-Hartman to remove possible conflict issue when merged.
>
> That's fine with me, should the MFD maintainer have been copied on this
> to get his signed-off-by on it?
>
I knew that first patch written by Thomas Abraham has been already
confirmed ack message from MFD maintainer(Samuel Ortiz
<sameo@linux.intel.com>). You can check it on first patch and below git
repository of Mark Brown.
The below patch has occurred build break, so it was reverted by Mark
Brown. And then I did post this patchset with bug fix.
http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=commit;h=98d8618af37728f6e18e84110ddb99987b47dd12
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] mfd: MAX8997: Support irq domain for Maxim MAX8997
2012-05-10 23:45 ` Chanwoo Choi
@ 2012-05-10 23:52 ` Greg KH
2012-05-11 0:38 ` Chanwoo Choi
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2012-05-10 23:52 UTC (permalink / raw)
To: Chanwoo Choi
Cc: broonie, thomas.abraham, myungjoo.ham, kyungmin.park,
jonghwa3.lee, linux-kernel, sameo@linux.intel.com
On Fri, May 11, 2012 at 08:45:23AM +0900, Chanwoo Choi wrote:
> On 05/11/2012 03:20 AM, Greg KH wrote:
>
> > On Thu, May 10, 2012 at 07:54:48PM +0900, Chanwoo Choi wrote:
> >> This patchset add support irq domain for Maxim MAX8997 interrupts.
> >>
> >> The first patch is based on patch written by Thomas Abraham and fix
> >> two bug which set max8997->irq_domain instead of NULL pointer and
> >> correct wrong parameter by Chanwoo Choi.
> >> - https://lkml.org/lkml/2012/4/18/145
> >> The second patch use irq domain for MAX8997 muic interrupt instead
> >> of irq_base in platform data of MAX8997 driver.
> >>
> >> But, I posted following patchset related to MAX8997 driver.
> >> This patchset support Extcon framework in extcon-max8997 driver to
> >> control external connector instead of max8997-muic driver. So, first
> >> patch add MAX8997 extcon driver(drivers/extcon/extcon-max8997.c) and
> >> last patch remove old MAX8997 muic driver(drivers/misc/max8997-muic.c).
> >> - https://lkml.org/lkml/2012/5/8/98
> >>
> >> This patchset was applied in below git repository of Greg Kroah-Hartman.
> >> - http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=shortlog;h=refs/heads/driver-core-next
> >>
> >> I think that this patchset should be applied on the git repository
> >> of Greg Kroah-Hartman to remove possible conflict issue when merged.
> >
> > That's fine with me, should the MFD maintainer have been copied on this
> > to get his signed-off-by on it?
> >
>
> I knew that first patch written by Thomas Abraham has been already
> confirmed ack message from MFD maintainer(Samuel Ortiz
> <sameo@linux.intel.com>). You can check it on first patch and below git
> repository of Mark Brown.
Ok, but why didn't you cc: him and everyone else who acked and
signed-off on that patch?
> The below patch has occurred build break, so it was reverted by Mark
> Brown. And then I did post this patchset with bug fix.
>
> http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=commit;h=98d8618af37728f6e18e84110ddb99987b47dd12
So does that mean this one is ok, but the older one isn't?
confused, what exactly should I do here?
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] mfd: MAX8997: Support irq domain for Maxim MAX8997
2012-05-10 23:52 ` Greg KH
@ 2012-05-11 0:38 ` Chanwoo Choi
0 siblings, 0 replies; 6+ messages in thread
From: Chanwoo Choi @ 2012-05-11 0:38 UTC (permalink / raw)
To: Greg KH
Cc: broonie, thomas.abraham, myungjoo.ham, kyungmin.park,
jonghwa3.lee, linux-kernel, sameo@linux.intel.com
On 05/11/2012 08:52 AM, Greg KH wrote:
> On Fri, May 11, 2012 at 08:45:23AM +0900, Chanwoo Choi wrote:
>> On 05/11/2012 03:20 AM, Greg KH wrote:
>>
>>> On Thu, May 10, 2012 at 07:54:48PM +0900, Chanwoo Choi wrote:
>>>>
>>>>
>>>> But, I posted following patchset related to MAX8997 driver.
>>>> This patchset support Extcon framework in extcon-max8997 driver to
>>>> control external connector instead of max8997-muic driver. So, first
>>>> patch add MAX8997 extcon driver(drivers/extcon/extcon-max8997.c) and
>>>> last patch remove old MAX8997 muic driver(drivers/misc/max8997-muic.c).
>>>> - https://lkml.org/lkml/2012/5/8/98
>>>>
>>>> This patchset was applied in below git repository of Greg Kroah-Hartman.
>>>> - http://git.kernel.org/?p=linux/kernel/git/gregkh/driver-core.git;a=shortlog;h=refs/heads/driver-core-next
>>>>
>>>> I think that this patchset should be applied on the git repository
>>>> of Greg Kroah-Hartman to remove possible conflict issue when merged.
>>>
>>> That's fine with me, should the MFD maintainer have been copied on this
>>> to get his signed-off-by on it?
>>>
>>
>> I knew that first patch written by Thomas Abraham has been already
>> confirmed ack message from MFD maintainer(Samuel Ortiz
>> <sameo@linux.intel.com>). You can check it on first patch and below git
>> repository of Mark Brown.
>
> Ok, but why didn't you cc: him and everyone else who acked and
> signed-off on that patch?
>
it is my mistake. I should have added maintainer related to first patch
as you said.
I will resend this patchset to all of people related to it now.
>> The below patch has occurred build break, so it was reverted by Mark
>> Brown. And then I did post this patchset with bug fix.
>>
>> http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=commit;h=98d8618af37728f6e18e84110ddb99987b47dd12
>
> So does that mean this one is ok, but the older one isn't?
>
> confused, what exactly should I do here?
>
Sorry, I have not sufficient explanation about history of patchset.
The below was written by Thomas Abraham and it was applied on
regulator.git repository.
http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=commit;h=98d8618af37728f6e18e84110ddb99987b47dd12
But, this patch had occurred build break, it was reported by Stephen
Rothwell when build max8997-muic driver(drivers/misc/max8997-muic.c) and
then this patch was reverted by Mark Brown. You can check reverted patch
on below patch.
http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=commit;h=82b719b11fd750188c125078ad6a6c0d23219dfb
Then, I posted patchset ,which is based on patch written by Thomas Abraham,
to add support irq domain for Max MAX8997 interrupts with bug fix.
I had to modify max8997-muic driver to avoid build break, But previously
I added extcon-max8997 driver and remove old max8997-muic
driver(drivers/misc/max8997-muic.c).
https://lkml.org/lkml/2012/5/8/98
So, I suggested that this patchset should be applied on the git reposity
of Greg
to remove possible conflict issue when merged because old max8997-muic
driver(drivers/misc/max8997-muic.c) is existed on regulator.git of Mark
Brown.
I am so sorry about obscure explanation of patchset history.
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/2] mfd: MAX8997: Support irq domain for Maxim MAX8997
@ 2012-06-21 1:10 Chanwoo Choi
0 siblings, 0 replies; 6+ messages in thread
From: Chanwoo Choi @ 2012-06-21 1:10 UTC (permalink / raw)
To: gregkh
Cc: thomas.abraham, broonie, grant.likely, sameo, myungjoo.ham,
kyungmin.park, linux-kernel, Chanwoo Choi
This patchset add support irq domain for Maxim MAX8997 interrupts.
I have discussed about this patchset with Greg KH and received below reply.
So, I resend this patchset.
- https://lkml.org/lkml/2012/5/20/142
This first patch is based on patch written by Thomas Abraham
(https://lkml.org/lkml/2012/4/18/145) but this patch had occurred
build break, it was reported by Stephen Rothwell and this patch was
reverted by Mark Brown. You can check reverted patch on below patch.
- http://git.kernel.org/?p=linux/kernel/git/broonie/regulator.git;a=commit;h=82b719b11fd750188c125078ad6a6c0d23219dfb
So I fix two bug which set max88997->irq_domain instead
of NULL pointer and correct wrong parameter.
The second patch use irq domain for muic interrupt of extcon-max8997
instead of irq_base in platform data of MAX8997 driver.
Chanwoo Choi (1):
Extcon: MAX8997: Add support irq domain for MAX8997 muic
Thomas Abraham (1):
mfd: add irq domain support for max8997 interrupts
arch/arm/mach-exynos/mach-nuri.c | 4 --
arch/arm/mach-exynos/mach-origen.c | 1 -
drivers/extcon/Kconfig | 2 +-
drivers/extcon/extcon-max8997.c | 29 ++++++++++------
drivers/mfd/Kconfig | 1 +
drivers/mfd/max8997-irq.c | 62 +++++++++++++++++++++--------------
drivers/mfd/max8997.c | 1 -
include/linux/mfd/max8997-private.h | 4 ++-
include/linux/mfd/max8997.h | 1 -
9 files changed, 60 insertions(+), 45 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-21 1:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-10 10:54 [PATCH 0/2] mfd: MAX8997: Support irq domain for Maxim MAX8997 Chanwoo Choi
2012-05-10 18:20 ` Greg KH
2012-05-10 23:45 ` Chanwoo Choi
2012-05-10 23:52 ` Greg KH
2012-05-11 0:38 ` Chanwoo Choi
-- strict thread matches above, loose matches on Subject: below --
2012-06-21 1:10 Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox