* [PATCH] usb/dwc3: Fix the dwc3 dependency
@ 2012-05-11 5:55 joseph daniel
2012-05-11 7:57 ` Felipe Balbi
2012-05-11 11:20 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: joseph daniel @ 2012-05-11 5:55 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-omap,
linux-kernel
Cc: joseph daniel
The warning shown up when ran with randconfig,
warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)
Signed-off-by: joseph daniel <josephdanielwalter@gmail.com>
---
drivers/usb/dwc3/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index d8f741f..68271fa 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -1,6 +1,6 @@
config USB_DWC3
tristate "DesignWare USB3 DRD Core Support"
- depends on (USB && USB_GADGET)
+ depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
select USB_OTG_UTILS
select USB_GADGET_DUALSPEED
select USB_GADGET_SUPERSPEED
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb/dwc3: Fix the dwc3 dependency
2012-05-11 5:55 [PATCH] usb/dwc3: Fix the dwc3 dependency joseph daniel
@ 2012-05-11 7:57 ` Felipe Balbi
2012-05-11 10:09 ` joseph daniel
2012-05-11 11:20 ` Sergei Shtylyov
1 sibling, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2012-05-11 7:57 UTC (permalink / raw)
To: joseph daniel
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-omap,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
On Fri, May 11, 2012 at 11:25:24AM +0530, joseph daniel wrote:
> The warning shown up when ran with randconfig,
>
> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)
>
> Signed-off-by: joseph daniel <josephdanielwalter@gmail.com>
> ---
> drivers/usb/dwc3/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index d8f741f..68271fa 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -1,6 +1,6 @@
> config USB_DWC3
> tristate "DesignWare USB3 DRD Core Support"
> - depends on (USB && USB_GADGET)
> + depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
^^^^
typo
I would prefer the select to change:
select XHCI_PLATFORM if (USB_SUPPORT && USB_XHCI_HCD)
or something similar.
> select USB_OTG_UTILS
> select USB_GADGET_DUALSPEED
> select USB_GADGET_SUPERSPEED
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb/dwc3: Fix the dwc3 dependency
2012-05-11 7:57 ` Felipe Balbi
@ 2012-05-11 10:09 ` joseph daniel
0 siblings, 0 replies; 4+ messages in thread
From: joseph daniel @ 2012-05-11 10:09 UTC (permalink / raw)
To: balbi; +Cc: Greg Kroah-Hartman, linux-usb, linux-omap, linux-kernel
Hi Felipe,
On Fri, May 11, 2012 at 1:27 PM, Felipe Balbi <balbi@ti.com> wrote:
> On Fri, May 11, 2012 at 11:25:24AM +0530, joseph daniel wrote:
>> The warning shown up when ran with randconfig,
>>
>> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT && USB_XHCI_HCD)
>>
>> Signed-off-by: joseph daniel <josephdanielwalter@gmail.com>
>> ---
>> drivers/usb/dwc3/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
>> index d8f741f..68271fa 100644
>> --- a/drivers/usb/dwc3/Kconfig
>> +++ b/drivers/usb/dwc3/Kconfig
>> @@ -1,6 +1,6 @@
>> config USB_DWC3
>> tristate "DesignWare USB3 DRD Core Support"
>> - depends on (USB && USB_GADGET)
>> + depends on (USB && USB_SUPPORT && USB_XCHI_HCD && USB_GADGET)
> ^^^^
> typo
>
> I would prefer the select to change:
>
> select XHCI_PLATFORM if (USB_SUPPORT && USB_XHCI_HCD)
>
will do this and send out a patch shotly.
> or something similar.
>
>> select USB_OTG_UTILS
>> select USB_GADGET_DUALSPEED
>> select USB_GADGET_SUPERSPEED
>
> --
> balbi
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb/dwc3: Fix the dwc3 dependency
2012-05-11 5:55 [PATCH] usb/dwc3: Fix the dwc3 dependency joseph daniel
2012-05-11 7:57 ` Felipe Balbi
@ 2012-05-11 11:20 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2012-05-11 11:20 UTC (permalink / raw)
To: joseph daniel
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-omap,
linux-kernel
Hello.
On 11-05-2012 9:55, joseph daniel wrote:
> The warning shown up when ran with randconfig,
> warning: (USB_DWC3) selects USB_XHCI_PLATFORM which has unmet direct dependencies (USB_SUPPORT&& USB_XHCI_HCD)
> Signed-off-by: joseph daniel<josephdanielwalter@gmail.com>
> ---
> drivers/usb/dwc3/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
> index d8f741f..68271fa 100644
> --- a/drivers/usb/dwc3/Kconfig
> +++ b/drivers/usb/dwc3/Kconfig
> @@ -1,6 +1,6 @@
> config USB_DWC3
> tristate "DesignWare USB3 DRD Core Support"
> - depends on (USB&& USB_GADGET)
> + depends on (USB&& USB_SUPPORT&& USB_XCHI_HCD&& USB_GADGET)
Parens not needed -- could as well get rid of them.
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-11 11:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-11 5:55 [PATCH] usb/dwc3: Fix the dwc3 dependency joseph daniel
2012-05-11 7:57 ` Felipe Balbi
2012-05-11 10:09 ` joseph daniel
2012-05-11 11:20 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox