From: Randy Dunlap <rdunlap@xenotime.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: [PATCH -next] via_wdt: depends on PCI
Date: Fri, 11 May 2012 16:37:22 -0700 [thread overview]
Message-ID: <4FADA2B2.8070302@xenotime.net> (raw)
In-Reply-To: <20120511162738.1d65b6efe099a54841be6313@canb.auug.org.au>
From: Randy Dunlap <rdunlap@xenotime.net>
via_wdt is a PCI driver so it should depend on PCI so that
it will not cause build errors.
drivers/watchdog/via_wdt.c:256:1: warning: data definition has no type or storage class
drivers/watchdog/via_wdt.c:256:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
drivers/watchdog/via_wdt.c:256:1: warning: parameter names (without types) in function declaration
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
drivers/watchdog/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20120511.orig/drivers/watchdog/Kconfig
+++ linux-next-20120511/drivers/watchdog/Kconfig
@@ -788,7 +788,7 @@ config SMSC37B787_WDT
config VIA_WDT
tristate "VIA Watchdog Timer"
- depends on X86
+ depends on X86 && PCI
select WATCHDOG_CORE
---help---
This is the driver for the hardware watchdog timer on VIA
next prev parent reply other threads:[~2012-05-11 23:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 6:27 linux-next: Tree for May 11 Stephen Rothwell
2012-05-11 23:19 ` linux-next: Tree for May 11 (printk) Randy Dunlap
2012-05-11 23:36 ` [PATCH -next] printk: add stub for prepend_timestamp() Randy Dunlap
2012-05-11 23:37 ` Randy Dunlap [this message]
2012-05-14 13:14 ` [PATCH -next] via_wdt: depends on PCI Wim Van Sebroeck
2012-05-11 23:52 ` linux-next: Tree for May 11 (perf_event_amd.c) Randy Dunlap
2012-05-12 1:33 ` [PATCH -next] watchdog: fix ie6xx_wdt.c printk format warning Randy Dunlap
2012-05-14 13:15 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FADA2B2.8070302@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).