From: Lars-Peter Clausen <lars@metafoo.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Harald Welte <laforge@gnumonks.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 2/2] mfd: pcf50633-core: Convert to use devm_* APIs
Date: Sat, 12 May 2012 07:45:34 +0200 [thread overview]
Message-ID: <4FADF8FE.5080705@metafoo.de> (raw)
In-Reply-To: <1336699889.8454.3.camel@phoenix>
On 05/11/2012 03:31 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Looks good...
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
[...]
> @@ -237,16 +236,11 @@ static int __devinit pcf50633_probe(struct i2c_client *client,
> pcf50633_irq_init(pcf, client->irq);
>
> /* Create sub devices */
> - pcf50633_client_dev_register(pcf, "pcf50633-input",
> - &pcf->input_pdev);
> - pcf50633_client_dev_register(pcf, "pcf50633-rtc",
> - &pcf->rtc_pdev);
> - pcf50633_client_dev_register(pcf, "pcf50633-mbc",
> - &pcf->mbc_pdev);
> - pcf50633_client_dev_register(pcf, "pcf50633-adc",
> - &pcf->adc_pdev);
> - pcf50633_client_dev_register(pcf, "pcf50633-backlight",
> - &pcf->bl_pdev);
> + pcf50633_client_dev_register(pcf, "pcf50633-input", &pcf->input_pdev);
> + pcf50633_client_dev_register(pcf, "pcf50633-rtc", &pcf->rtc_pdev);
> + pcf50633_client_dev_register(pcf, "pcf50633-mbc", &pcf->mbc_pdev);
> + pcf50633_client_dev_register(pcf, "pcf50633-adc", &pcf->adc_pdev);
> + pcf50633_client_dev_register(pcf, "pcf50633-backlight", &pcf->bl_pdev);
>
>[...]
... but this is really a unrelated change, which isn't even mentioned in the
changelog.
next prev parent reply other threads:[~2012-05-12 5:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 1:29 [PATCH 1/2] mfd: da9052: Convert to use devm_* APIs Axel Lin
2012-05-11 1:31 ` [PATCH 2/2] mfd: pcf50633-core: " Axel Lin
2012-05-12 5:45 ` Lars-Peter Clausen [this message]
2012-05-11 13:46 ` [PATCH 1/2] mfd: da9052: " Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FADF8FE.5080705@metafoo.de \
--to=lars@metafoo.de \
--cc=axel.lin@gmail.com \
--cc=laforge@gnumonks.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).