From: Laxman Dewangan <ldewangan@nvidia.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: tps62360: Fix build error due to missing semicolon
Date: Mon, 14 May 2012 22:03:41 +0530 [thread overview]
Message-ID: <4FB133E5.30301@nvidia.com> (raw)
In-Reply-To: <4FB12EA3.504@nvidia.com>
On Monday 14 May 2012 09:41 PM, Laxman Dewangan wrote:
> On Monday 14 May 2012 09:28 PM, Axel Lin wrote:
>> Fix below build error:
>> CC [M] drivers/regulator/tps62360-regulator.o
>> drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'
>> make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
>> make[1]: *** [drivers/regulator] Error 2
>> make: *** [drivers] Error 2
>>
>> Signed-off-by: Axel Lin<axel.lin@gmail.com>
>> ---
>> drivers/regulator/tps62360-regulator.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/regulator/tps62360-regulator.c b/drivers/regulator/tps62360-regulator.c
>> index 60765cc..82cd763 100644
>> --- a/drivers/regulator/tps62360-regulator.c
>> +++ b/drivers/regulator/tps62360-regulator.c
>> @@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
>> { .compatible = "ti,tps62362", .data = (void *)TPS62362},
>> { .compatible = "ti,tps62363", .data = (void *)TPS62363},
>> {},
>> -}
>> +};
>> MODULE_DEVICE_TABLE(of, tps62360_of_match);
>> #endif
>>
> Really strange!! I am not getting this compilation error in my build.
>
> Acked-by: Laxman Dewangan<ldewangan@nvidia.com>
>
Got reproduced this error if I compile the driver as module.
Now onwards, I will compile as y and m for any change.
Sorry for inconvenience and thanks for fixing this.
next prev parent reply other threads:[~2012-05-14 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 15:58 [PATCH] regulator: tps62360: Fix build error due to missing semicolon Axel Lin
2012-05-14 16:11 ` Laxman Dewangan
2012-05-14 16:33 ` Laxman Dewangan [this message]
2012-05-14 16:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB133E5.30301@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox