linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Airlie <airlied@gmail.com>
Cc: linux-kernel@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
	Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH] x86/vga: set the default device from the fixup.
Date: Mon, 14 May 2012 09:51:23 -0700	[thread overview]
Message-ID: <4FB1380B.3020802@zytor.com> (raw)
In-Reply-To: <1337011280-7166-1-git-send-email-airlied@gmail.com>

On 05/14/2012 09:01 AM, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> Since Matthew's efi/vga changes on non-EFI machines we were failing
> to tell the vgaarb/switcheroo what the default device was, this
> sets the default device in the quirk if none has been set before.
> 
> This fixes the switcheroo on my T410s.
> 
> [hpa: please ack to put this on top of the other patches in my -next tree].
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> Cc: Matthew Garrett <mjg@redhat.com>
> Cc: H. Peter Anvin <hpa@zytor.com>

Acked-by: H. Peter Anvin <hpa@zytor.com>

... although I would prefer the

	if (!vga_default_device())

syntax as a matter of style.

	-hpa

      reply	other threads:[~2012-05-14 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 16:01 [PATCH] x86/vga: set the default device from the fixup Dave Airlie
2012-05-14 16:51 ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB1380B.3020802@zytor.com \
    --to=hpa@zytor.com \
    --cc=airlied@gmail.com \
    --cc=airlied@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).