* [PATCH V1] gpio: fix bits conflict for gpio flags
@ 2012-05-07 10:25 Laxman Dewangan
2012-05-14 17:04 ` Laxman Dewangan
0 siblings, 1 reply; 2+ messages in thread
From: Laxman Dewangan @ 2012-05-07 10:25 UTC (permalink / raw)
To: grant.likely, linus.walleij; +Cc: w.sang, linux-kernel, Laxman Dewangan
The bit 2 and 3 in GPIO flag are allocated for the
flag OPEN_DRAIN/OPEN_SOURCE. These bits are reused
for the flag EXPORT/EXPORT_CHANGEABLE and so creating
conflict.
Fix this conflict by allocating bit 4 and 5 for the
flag EXPORT/EXPORT_CHANGEABLE.
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
This is broken by commit
commit fc3a1f04f5040255cbc086c419e4237f29f89f88
Author: Wolfram Sang <w.sang@pengutronix.de>
gpio: add flags to export GPIOs when requesting
include/linux/gpio.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/gpio.h b/include/linux/gpio.h
index d1890d4..0118141 100644
--- a/include/linux/gpio.h
+++ b/include/linux/gpio.h
@@ -20,8 +20,8 @@
/* Gpio pin is open source */
#define GPIOF_OPEN_SOURCE (1 << 3)
-#define GPIOF_EXPORT (1 << 2)
-#define GPIOF_EXPORT_CHANGEABLE (1 << 3)
+#define GPIOF_EXPORT (1 << 4)
+#define GPIOF_EXPORT_CHANGEABLE (1 << 5)
#define GPIOF_EXPORT_DIR_FIXED (GPIOF_EXPORT)
#define GPIOF_EXPORT_DIR_CHANGEABLE (GPIOF_EXPORT | GPIOF_EXPORT_CHANGEABLE)
--
1.7.1.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V1] gpio: fix bits conflict for gpio flags
2012-05-07 10:25 [PATCH V1] gpio: fix bits conflict for gpio flags Laxman Dewangan
@ 2012-05-14 17:04 ` Laxman Dewangan
0 siblings, 0 replies; 2+ messages in thread
From: Laxman Dewangan @ 2012-05-14 17:04 UTC (permalink / raw)
To: Laxman Dewangan
Cc: grant.likely@secretlab.ca, linus.walleij@stericsson.com,
w.sang@pengutronix.de, linux-kernel@vger.kernel.org
Grant,
On Monday 07 May 2012 03:55 PM, Laxman Dewangan wrote:
> The bit 2 and 3 in GPIO flag are allocated for the
> flag OPEN_DRAIN/OPEN_SOURCE. These bits are reused
> for the flag EXPORT/EXPORT_CHANGEABLE and so creating
> conflict.
> Fix this conflict by allocating bit 4 and 5 for the
> flag EXPORT/EXPORT_CHANGEABLE.
>
> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
> ---
> This is broken by commit
> commit fc3a1f04f5040255cbc086c419e4237f29f89f88
> Author: Wolfram Sang<w.sang@pengutronix.de>
>
> gpio: add flags to export GPIOs when requesting
>
It would be good if it go to 3.5.
Thanks,
Laxman
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-14 17:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-07 10:25 [PATCH V1] gpio: fix bits conflict for gpio flags Laxman Dewangan
2012-05-14 17:04 ` Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).