Re: [PATCH 3/5] st: get rid of scsi_tapes array

[Lee Duncan <lduncan@suse.com>]

Ok, understood.

On 05/17/2012 12:35 AM, James Bottomley wrote:
> On Wed, 2012-05-16 at 20:56 -0700, Lee Duncan wrote:
>> st currently allocates an array to store pointers to all of the
>> scsi_tape objects. It's used to discover available indexes to use as the
>> base for the minor number selection and later to look up scsi_tape
>> devices for character devices.
>>
>> We switch to using an IDR for minor selection and a pointer from
>> st_modedef back to scsi_tape for the lookups.
>>
>> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
>> Reviewed-by: Lee Duncan <lduncan@suse.com>
> 
> This can't be Reviewed-by either.  The signoff chain has to follow the
> transmission path of the patch.  If you send me Jeff's patches, you have
> to add a signoff because you're a direct part of the transmission path.
> If Jeff sends me them, then he can give you Reviewed-by because you're
> not then in the direct transmission path.  (Signoff is supposed to imply
> reviewed by anyway, so the tagging is correct in either case).
> 
> James
> 
> 
> 

-- 
Lee Duncan