From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: mathieu.poirier@linaro.org
Cc: mchehab@infradead.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH 2/6] v4l/dvb: fix Kconfig dependencies on VIDEO_CAPTURE_DRIVERS
Date: Tue, 15 May 2012 07:47:22 -0300 [thread overview]
Message-ID: <4FB2343A.3080608@redhat.com> (raw)
In-Reply-To: <4FB23381.5020007@redhat.com>
Em 15-05-2012 07:44, Mauro Carvalho Chehab escreveu:
> Em 03-05-2012 19:22, mathieu.poirier@linaro.org escreveu:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Kconfig warns about unsatisfied dependencies of symbols that
>> are directly selected.
>>
>> Many capture drivers depend on DVB capture drivers, which
>> are hidden behind the CONFIG_DVB_CAPTURE_DRIVERS setting.
>>
>> The solution here is to enable DVB_CAPTURE_DRIVERS unconditionally
>> when both DVB and VIDEO_CAPTURE_DRIVERS are enabled.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
>> ---
>> drivers/media/dvb/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/media/dvb/Kconfig b/drivers/media/dvb/Kconfig
>> index f6e40b3..c617996 100644
>> --- a/drivers/media/dvb/Kconfig
>> +++ b/drivers/media/dvb/Kconfig
>> @@ -29,7 +29,7 @@ config DVB_DYNAMIC_MINORS
>> If you are unsure about this, say N here.
>>
>> menuconfig DVB_CAPTURE_DRIVERS
>> - bool "DVB/ATSC adapters"
>> + bool "DVB/ATSC adapters" if !VIDEO_CAPTURE_DRIVERS
>> depends on DVB_CORE
>> default y
>> ---help---
>
> No, this is not right. Users can select either DVB or V4L2 (or hybrid)
> devices independently.
>
> If now a warning is happening, is because something changed Kconfig
> behavior on some non-expected way.
I remember a similar bug in the past that it was solved by using a new
Kconfig dialect "visible if".
Not sure it this applies here.
>
> Nack.
>
> Regards,
> Mauro
next prev parent reply other threads:[~2012-05-15 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 22:22 [PATCH 0/6] drivers/media: randconfig patches for kernel 3.4 mathieu.poirier
2012-05-03 22:22 ` [PATCH 1/6] drivers/media: add missing __devexit_p() annotations mathieu.poirier
2012-05-03 22:22 ` [PATCH 2/6] v4l/dvb: fix Kconfig dependencies on VIDEO_CAPTURE_DRIVERS mathieu.poirier
2012-05-15 10:44 ` Mauro Carvalho Chehab
2012-05-15 10:47 ` Mauro Carvalho Chehab [this message]
2012-05-03 22:22 ` [PATCH 3/6] media/rc: IR_SONY_DECODER depends on BITREVERSE mathieu.poirier
2012-05-03 22:22 ` [PATCH 4/6] media/video: add I2C dependencies mathieu.poirier
2012-05-03 22:22 ` [PATCH 5/6] dvb/drxd: stub out drxd_attach when not built mathieu.poirier
2012-05-03 22:22 ` [PATCH 6/6] video/omap24xxcam: use __iomem annotations mathieu.poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB2343A.3080608@redhat.com \
--to=mchehab@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox