From: Pavel Emelyanov <xemul@parallels.com>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
James Bottomley <jbottomley@parallels.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [rfc 3/4] fs, eventfd: Add procfs fdinfo helper
Date: Thu, 17 May 2012 20:34:59 +0400 [thread overview]
Message-ID: <4FB528B3.8000406@parallels.com> (raw)
In-Reply-To: <20120517162534.755208902@openvz.org>
> +static void *seq_start(struct seq_file *m, loff_t *pos)
> +{
> + struct proc_fdinfo_extra *extra = m->private;
> + return *pos == 1 ? extra->fd_file : NULL;
> +}
> +
> +static void seq_stop(struct seq_file *m, void *v)
> +{
> +}
> +
> +static void *seq_next(struct seq_file *m, void *p, loff_t *pos)
> +{
> + struct proc_fdinfo_extra *extra = m->private;
> + return ++*pos == 1 ? extra->fd_file : NULL;
> +}
> +
<snip>
> +static const struct seq_operations eventfd_fdinfo_ops = {
> + .start = seq_start,
> + .next = seq_next,
> + .stop = seq_stop,
> + .show = seq_show,
I think, you can use the single_ part of the seq files engine.
> +};
Thanks,
Pavel
next prev parent reply other threads:[~2012-05-17 16:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 16:07 [rfc 0/4] procfs fdinfo extension Cyrill Gorcunov
2012-05-17 16:07 ` [rfc 1/4] procfs: Move /proc/pid/fd[info] handling code to fd.[ch] Cyrill Gorcunov
2012-05-17 16:07 ` [rfc 2/4] procfs: Convert /proc/pid/fdinfo/fd handling routines into seq-file with fdinfo helpers Cyrill Gorcunov
2012-05-17 16:32 ` Pavel Emelyanov
2012-05-17 17:38 ` Cyrill Gorcunov
2012-05-17 21:49 ` Cyrill Gorcunov
2012-05-17 16:07 ` [rfc 3/4] fs, eventfd: Add procfs fdinfo helper Cyrill Gorcunov
2012-05-17 16:34 ` Pavel Emelyanov [this message]
2012-05-17 17:43 ` Cyrill Gorcunov
2012-05-17 16:07 ` [rfc 4/4] fs, epoll: " Cyrill Gorcunov
2012-05-17 16:29 ` [rfc 0/4] procfs fdinfo extension Pavel Emelyanov
2012-05-17 19:05 ` Andrew Morton
2012-05-17 19:28 ` Cyrill Gorcunov
2012-05-18 11:53 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB528B3.8000406@parallels.com \
--to=xemul@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=jbottomley@parallels.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox